[jira] [Work logged] (HIVE-23754) LLAP: Add LoggingHandler in ShuffleHandler pipeline for better debuggability

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-23754?focusedWorklogId=827055&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827055 ]

ASF GitHub Bot logged work on HIVE-23754:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Nov/22 07:07
            Start Date: 18/Nov/22 07:07
    Worklog Time Spent: 10m 
      Work Description: abstractdog commented on code in PR #3669:
URL: https://github.com/apache/hive/pull/3669#discussion_r1026089228


##########
llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java:
##########
@@ -390,6 +392,9 @@ public void initChannel(NioSocketChannel ch) throws Exception {
         if (sslFactory != null) {
           pipeline.addLast("ssl", new SslHandler(sslFactory.createSSLEngine()));
         }
+        if (LOG.isDebugEnabled()) {
+          pipeline.addLast("loggingHandler", new LoggingHandler(LogLevel.INFO));

Review Comment:
   makes sense, but if we're about to do it on DEBUG level, wouldn't it rather be:
   ```
   new LoggingHandler(LogLevel.DEBUG)
   ```
   
   





Issue Time Tracking
-------------------

    Worklog Id:     (was: 827055)
    Time Spent: 1h  (was: 50m)

> LLAP: Add LoggingHandler in ShuffleHandler pipeline for better debuggability
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-23754
>                 URL: https://issues.apache.org/jira/browse/HIVE-23754
>             Project: Hive
>          Issue Type: Improvement
>         Environment:  
>  
>            Reporter: Rajesh Balamohan
>            Assignee: Dmitriy Fingerman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java#L616]
>  
> For corner case debugging, it would be helpful to understand when netty processed OPEN/BOUND/CLOSE/RECEIVED/CONNECTED events along with payload details.
> Adding "LoggingHandler" in ChannelPipeline mode can help in debugging.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)