You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Josh Yeh via Review Board <no...@reviews.apache.org> on 2021/04/30 07:39:58 UTC

Review Request 73317: ATLAS-3812: Add schema for Apache Flink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry and Sarath Subramanian.


Repository: atlas


Description
-------

ATLAS-3812: Add schema for Apache Flink


Diffs
-----

  addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 


Diff: https://reviews.apache.org/r/73317/diff/1/


Testing
-------

Tested on my CDH cluster with flink example wordcount streaming job.


File Attachments
----------------

Screen Shot 2021-04-30 at 12.38.27 AM.png
  https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png


Thanks,

Josh Yeh


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review223102
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On June 1, 2021, 6:59 p.m., Josh Yeh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> -----------------------------------------------------------
> 
> (Updated June 1, 2021, 6:59 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -----
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/4/
> 
> 
> Testing
> -------
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review223094
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On June 1, 2021, 6:59 p.m., Josh Yeh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> -----------------------------------------------------------
> 
> (Updated June 1, 2021, 6:59 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -----
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/4/
> 
> 
> Testing
> -------
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review223088
-----------------------------------------------------------



Thanks for the patch. The model looks good.
Can you please attach a screen shot (like you did before) that create entities using the new model? That will provide us with a good reference.
It will also help if you can attach the JSON that is used to create the entities.

- Ashutosh Mestry


On June 1, 2021, 6:59 p.m., Josh Yeh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> -----------------------------------------------------------
> 
> (Updated June 1, 2021, 6:59 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -----
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/4/
> 
> 
> Testing
> -------
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Josh Yeh via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/
-----------------------------------------------------------

(Updated June 1, 2021, 6:59 p.m.)


Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.


Repository: atlas


Description
-------

ATLAS-3812: Add schema for Apache Flink


Diffs (updated)
-----

  addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 


Diff: https://reviews.apache.org/r/73317/diff/4/

Changes: https://reviews.apache.org/r/73317/diff/3-4/


Testing
-------

Tested on my CDH cluster with flink example wordcount streaming job.


File Attachments
----------------

Screen Shot 2021-04-30 at 12.38.27 AM.png
  https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png


Thanks,

Josh Yeh


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Josh Yeh via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/
-----------------------------------------------------------

(Updated June 1, 2021, 6:55 p.m.)


Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.


Repository: atlas


Description
-------

ATLAS-3812: Add schema for Apache Flink


Diffs (updated)
-----

  addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java f9548244364a8f79f346411739348d0d53298c99 
  addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
  build-tools/src/main/resources/ui-dist/index.html 653c38b1614680ea58d7a72aa0a3a9370ec28e31 
  build-tools/src/main/resources/ui-dist/index.js 3ae40764c6cde3ee13a0fcb94e9e0a437ac530bc 
  common/src/main/java/org/apache/atlas/CommonConfiguration.java edea42ba8b92722c7a90af690c409cb648bb4255 
  common/src/main/java/org/apache/atlas/annotation/Timed.java b892a16c743ba6747b51bb849f3d9f2164e33d9c 
  common/src/main/java/org/apache/atlas/repository/Constants.java aea0c13111b1928a4ac3b687dcc904e729e4deaa 
  common/src/main/java/org/apache/atlas/utils/KafkaUtils.java 16744225977088e86fa81649a1413182fdc0ffb8 
  common/src/test/java/org/apache/atlas/utils/KafkaUtilsTest.java 562e28ae1e6d992ea03babe2200185d8aae076c9 
  dashboardv2/package-lock.json 61fd944c6223985efaff10f25a69f590da30d7d6 
  dashboardv2/public/css/scss/override.scss c51a23c3f684f1944b960cfe3888bc3b7ccaf1a7 
  dashboardv2/public/css/scss/tab.scss c164b47440d35482ce222e95408b0b29c514c7de 
  dashboardv2/public/css/scss/table.scss 121769b18c57df2c74b211e563b17d373860f4b4 
  dashboardv2/public/css/scss/theme.scss 4838ca3afb91830084dfd83ad9fd5cb6d26c7f2a 
  dashboardv2/public/js/external_lib/atlas-lineage/dist/index.js 1ff212838e284cbdee092f325f4dad2a6a4c2a33 
  dashboardv2/public/js/main.js 7c8bbb48768382bee8df53cd72d0b995b0a152d6 
  dashboardv2/public/js/router/Router.js ea26bf5c08eb3dae14dd26cfe11b794a58f279b9 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html ee4b9431fdf3d8bda3ed9db16abe1c19eaa04aae 
  dashboardv2/public/js/templates/detail_page/PendingTaskTableLayoutView_tmpl.html 059c42f69090ba8e90570927a9d1b958ccdfb862 
  dashboardv2/public/js/templates/dev_debug/DebugMetricsLayoutView_tmpl.html 78d91bf13c8f51a12cda4215b030418cb67f92c6 
  dashboardv2/public/js/templates/site/DebugMetricsTableLayoutView_tmpl.html 8b543680a2a61a22060ac141a9ffd1d9544fc6f5 
  dashboardv2/public/js/templates/site/Header.html 572e39e7804a97102c60e7e980ed309e8662c24a 
  dashboardv2/public/js/templates/site/MetricsUIInfoView_tmpl.html 837c3b5bf9c1fd160d7ab49a109bff4a8f6937a5 
  dashboardv2/public/js/utils/CommonViewFunction.js bb3fa3fecd9ee2949cf3a9b27646190f5ab66133 
  dashboardv2/public/js/utils/Globals.js b0dc5cd77506ed19b1f2338bf9ea7868e027fd72 
  dashboardv2/public/js/utils/UrlLinks.js eb2980c11850f4ec2ab4c9bd6774d755de87a78b 
  dashboardv2/public/js/utils/Utils.js f426b6c98aa1cb89d8f06196c765830ba0e7285f 
  dashboardv2/public/js/views/audit/AuditTableLayoutView.js 625ae87c5d86280e53d390ed28dd08897b43ffe5 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js d8e10cce02b1a68fdbf54ae0535a83b0aa2cc5b2 
  dashboardv2/public/js/views/detail_page/PendingTaskTableLayoutView.js 0e32ebe7a34062f1e525daccc6ddda59705035f0 
  dashboardv2/public/js/views/dev_debug/DebugMetricsLayoutView.js 375d551c2f6629ae454226437595a4021a0a8b43 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 5ad657e2552247b263c9bd5b2d10f4304de72b95 
  dashboardv2/public/js/views/import/ImportLayoutView.js 88d553c6f0f2d9fed2823e39f7260e0b390cfc8c 
  dashboardv2/public/js/views/site/DebugMetricsTableLayoutView.js 407e489adb93599e54af4bc51a36cb583c3706f1 
  dashboardv2/public/js/views/site/Header.js ffb582ed4bbf80775c15a52a56f3231bebd0e5a8 
  dashboardv2/public/js/views/site/MetricsUIInfoView.js f46b5b84f57b5018e5d4b1d1a675907e933e0c43 
  dashboardv2/public/js/views/site/SideNavLayoutView.js e0f717a24cff8fda6c634f4d0e56784d526528c1 
  dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js 9b8b90fc63a98c5d9b0a13541d7c28afff16378b 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c780deb7d33ee2ee60714ba908fea21c1a032262 
  dashboardv2/public/js/views/tag/TagLayoutView.js f40846953913531d13b0272ab68fe19d91dd60c4 
  dashboardv3/package-lock.json 2b00b159e41246e9033466472e69e217cb3a7349 
  dashboardv3/public/css/scss/override.scss 280afd694d4559cd7cd7a2d0dc6e7cb35071e15a 
  dashboardv3/public/css/scss/tab.scss c164b47440d35482ce222e95408b0b29c514c7de 
  dashboardv3/public/css/scss/table.scss 121769b18c57df2c74b211e563b17d373860f4b4 
  dashboardv3/public/js/external_lib/atlas-lineage/dist/index.js 1ff212838e284cbdee092f325f4dad2a6a4c2a33 
  dashboardv3/public/js/main.js 374641ee01b697f9b74d7cc3888fb4e885f1a88e 
  dashboardv3/public/js/router/Router.js bd50715576e6084bd0bb71f3a6da6095fa754b17 
  dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html b209a49e4af62f211d62e3692b887de78dbb42af 
  dashboardv3/public/js/templates/detail_page/PendingTaskTableLayoutView_tmpl.html 059c42f69090ba8e90570927a9d1b958ccdfb862 
  dashboardv3/public/js/templates/dev_debug/DebugMetricsLayoutView_tmpl.html 78d91bf13c8f51a12cda4215b030418cb67f92c6 
  dashboardv3/public/js/templates/site/DebugMetricsTableLayoutView_tmpl.html 8b543680a2a61a22060ac141a9ffd1d9544fc6f5 
  dashboardv3/public/js/templates/site/Header.html a8ff7f9b5c3bf27a074184f3a2dd34e1a58e3c4a 
  dashboardv3/public/js/templates/site/MetricsUIInfoView_tmpl.html 837c3b5bf9c1fd160d7ab49a109bff4a8f6937a5 
  dashboardv3/public/js/utils/CommonViewFunction.js 34afa2d20c6b2fa4523ff1d736f4f7bbf6b9c5a1 
  dashboardv3/public/js/utils/Globals.js b0dc5cd77506ed19b1f2338bf9ea7868e027fd72 
  dashboardv3/public/js/utils/UrlLinks.js b500ebdd7e54f78a8ac8f257fbc5004a39f20769 
  dashboardv3/public/js/utils/Utils.js 1a73b7c14649d55ce7541178b13a2373ea6136f2 
  dashboardv3/public/js/views/audit/AuditTableLayoutView.js 625ae87c5d86280e53d390ed28dd08897b43ffe5 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 8e0686bb7c525825b3d9d70713f27b54ce4798ec 
  dashboardv3/public/js/views/detail_page/PendingTaskTableLayoutView.js 0e32ebe7a34062f1e525daccc6ddda59705035f0 
  dashboardv3/public/js/views/dev_debug/DebugMetricsLayoutView.js 375d551c2f6629ae454226437595a4021a0a8b43 
  dashboardv3/public/js/views/graph/LineageLayoutView.js 954d9afbda05d1b1d0ebe1fc2434ca67974021cb 
  dashboardv3/public/js/views/import/ImportLayoutView.js 88d553c6f0f2d9fed2823e39f7260e0b390cfc8c 
  dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 75e53cdb6fd9aa2d20a91a4fbca9c4c98b02f17d 
  dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js e58b17780abb13e6a0d9d9aa75a32de5292e9564 
  dashboardv3/public/js/views/site/DebugMetricsTableLayoutView.js 407e489adb93599e54af4bc51a36cb583c3706f1 
  dashboardv3/public/js/views/site/Header.js e2ecd7e725d610cf692f91b9357f28cf94376470 
  dashboardv3/public/js/views/site/MetricsUIInfoView.js f46b5b84f57b5018e5d4b1d1a675907e933e0c43 
  dashboardv3/public/js/views/tag/TagAttributeDetailLayoutView.js 6e10155240c1f3e3ff18275131376dddb5568612 
  dashboardv3/public/js/views/tag/TagDetailTableLayoutView.js 809c1439213d1f1ba9b48d2d53114ae7cc38bbd8 
  distro/src/conf/hadoop-metrics2.properties 52c1d4fc80b79a5e27a9d69e1c452fbee75036e5 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java adc552899f78b0a4b58a98e150fcc2430e6e1d14 
  graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java 58e2b64f5e81b7f51561f967a0e34e91076910c2 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e31afa89ae0a4a431744bba9883237fd4179167b 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2febff469de28c1b527b2f4ccba039b41675fd11 
  intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java ce0f84b6e0120db89f534b93ea0a6dd60dfe6c3e 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 78fb4a48f8165fe2df865a1ff1925f9b3c4a803a 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java f0f362b3e4e7056f7c7ae5d2bfde34b3edc602d8 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java f807ba2438de4669d5cfe7f8d4da6941ba3d5030 
  intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java f22521364be4dd3aa22797f436c5b8e15a58c25f 
  intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationMessage.java 5869910cbed689c2789b052e10edc96d43f8e1d2 
  intg/src/main/python/apache_atlas/client/entity.py 14cb4ed602411b70d0988482726d5ed69468ba3d 
  intg/src/main/python/apache_atlas/utils.py 01d0762be267e2474789bb28959aa9e4684fc52e 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 96dc5856af39c89e509a87af1d91db3c61942092 
  notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java af3727df457421e78e4a6e0b3b0a3f791b430b50 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 32f5183a00ae7d4437e8d44249204716d5c7b02d 
  notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java b43bc7c66a7a73c655d19ddf36eb214fa5da7283 
  notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java 3d8d9cc0a06d5b64b8359e14585205cf8e1cbc98 
  notification/src/main/java/org/apache/atlas/notification/spool/AtlasFileSpool.java ea3128465c03cd6125b74ceedf718ee37ed11aa0 
  notification/src/main/java/org/apache/atlas/notification/spool/IndexManagement.java f018983a4135e472f12a4716cf6e4c3a5f0db3c9 
  notification/src/main/java/org/apache/atlas/notification/spool/Publisher.java 01ead7db503420e56cb398983c4151897a19fa2f 
  notification/src/main/java/org/apache/atlas/notification/spool/SpoolConfiguration.java 76f05efea73432285f49be6b921e51d9792f24de 
  notification/src/main/java/org/apache/atlas/notification/spool/Spooler.java a918e9bb1dd31a9a5608e47bf635239d81874df1 
  notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java 8078a6ceb39f2c5044a83f3d91690a66ac7b5c32 
  notification/src/test/java/org/apache/atlas/notification/spool/AtlasFileSpoolTest.java 265598eeb7682f384b6011369c9735d7042e8311 
  notification/src/test/java/org/apache/atlas/notification/spool/BaseTest.java 304c8212219ed3c7c7da4658561fba065a5c8987 
  pom.xml 91c23ee044fed1b181d5ceeab9c16c54cff31bc7 
  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java dfcc441ccb1c1febd1907ac97e95bba85887984a 
  repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java f2290c672cb24a2ff410a94acbb2acff9af90dd1 
  repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java f45ccaf24f29500ddff1701ff160ea2ebcd409eb 
  repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java 86f2cea236b1b94b016368a6c9ad9f1ba83cefdb 
  repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 2d8a448b13dd3bbab52aef3dc61ba9d4effbaaea 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 01954d07e5e7a11c0f90e7849be31c33e55dc8e0 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java f69dc42157befb9563368d9559452bf01ea348ce 
  repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java b8a507eac87edad05866345a365e749fc010840e 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9c8459874268f870349b09e76fa2bc638cf8e197 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java d92daeea59f05dddb605b76bf557c74b3c9690cb 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java ddfb0089ed6902522f48200dfb8f4a4bc5e85150 
  repository/src/main/java/org/apache/atlas/repository/store/graph/EntityCorrelationStore.java 4760757ff59023650e2d025cea2aebd87870936b 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f118ae69abe3f695a7c6fed95699f28941aad881 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 0f12bd31e051489683681a1f1e74c7c567bf70df 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java e73f084b883fa316b41ba20570f5d929c1226c2d 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2.java 7bc4b28c36498b4b0ce469b98d62eb4fae7f6fb7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java b51cbfc78bebb9f1b6c323f83bcf5a6eb667caa6 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 794847555a22d4ae1ae46307478515a78a32f0f5 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagateTaskFactory.java b3320c60763c827bc409ad9498d6b8a1c72716ca 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagationTasks.java aec5b0cf7bbb4d8528abd797cd423c2047f909ce 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java 00c9caaa7a6fda68bb179279912de53782d23b4d 
  repository/src/main/java/org/apache/atlas/tasks/TaskFactoryRegistry.java 4c93f0eeeb8720997fa37badb1d6b1347cdf712a 
  repository/src/main/java/org/apache/atlas/tasks/TaskManagement.java 9a519bacc50d7fe40618442f2f4604c528799835 
  repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java a9fbd435af19d22b4c973ec70de9e46a0c82249e 
  repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java 121dca9f53d522a29f8933a83de53b2b98268e7d 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v2/DifferentialAuditsTest.java d10774f3daa82bb25b9e0cc091dc95fb49f7b337 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v2/EntityCorrelationStoreTest.java a3be5f4ed282346b39a94180c8beaa60f9fb0a24 
  repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationWithTasksTest.java d440f2f2dd9a01e2d15625dc338a35a172fa3257 
  repository/src/test/resources/json/entities/db01.json 470d180395bb5a0213e4f7006c7d2109fa046d63 
  repository/src/test/resources/json/entities/tbl01-2cols.json 52f34cd921fdb1289057e1a484cfb74ad4385547 
  repository/src/test/resources/json/entities/tbl01.json 50251f0fe5c84887e6c0fce5bb67830ebe508f52 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb3633dcb8c471e4a221bd6b54bc418e160 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 5309d199394193b6e18726a39337eaa0e4e06bec 
  webapp/src/main/java/org/apache/atlas/notification/EntityCorrelationManager.java f1d6aff463466594be29e16690c391435deb2b4a 
  webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 5643af95c05331054194d78d975b2202839c7387 
  webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java 7f0cafe86b074706339e4b86060fa38b0ef91a6c 
  webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveDbDDLPreprocessor.java dcff0939d335735eb6719f8f29737c799a75c835 
  webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java bf6a623fe8016a71fcbf76962507ec96c293a8e4 
  webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveTableDDLPreprocessor.java 83d4d7c1a26101d44663d50b7b0f7be2d319b367 
  webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java 59f6440d51d0339c20bb6a5dd4979fb00c0ba144 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 429ff1cf948fceb65380a93fd4aa0641b9504a43 
  webapp/src/main/java/org/apache/atlas/web/model/DebugMetrics.java 856a6fbecf8116fe648106c63601e00db0813d75 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 01fb8ec0292cd97fd66ef5a6597a80f6bae9176e 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e4c74a9d1a4b5a471a4423244d6e758bcb5bc60b 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 05d7d13f7ae8120a14346859fc28b855ff88924a 
  webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java c1de83be9a5f90b2cd9f631dd0bd2d48c21955f9 
  webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java 30b5626072f76a1ae77ca459be5e8f88ec6a125b 
  webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java 04114d9e67ddcfa8f4867de832ea249bbcb7d890 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 30786dc9dc80072d26c31c090c96dd7a1fd3370c 
  webapp/src/main/java/org/apache/atlas/web/service/AtlasDebugMetricsSink.java ef24b861ea08edeac794c1edf24e052d48d5e8a8 
  webapp/src/main/java/org/apache/atlas/web/service/AtlasDebugMetricsSource.java 63e979ac2f6bfaadf2904c0cdee5a457f1b69887 
  webapp/src/main/java/org/apache/atlas/web/service/DebugMetricsWrapper.java 0d2da1b97ecbaf86fe431b348436579c11123f05 
  webapp/src/main/java/org/apache/atlas/web/service/TimedAspectInterceptor.java 64225d0619c08ce5cb36271c9ef84babb46b0144 
  webapp/src/main/webapp/WEB-INF/web.xml 7fb56efded4eccbe28ac8443f77c72f741e50bcb 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java fdfc2560de4f68c622c2bbffecaa20ad5f6331fd 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java f440c4293cfa0a00fd248c405fa321e2ccd31e98 
  webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java 841cfaf941f584c31a183ea31f1c6a332fc8a706 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 9d5a9e5c38343029bcfa0fbced8c7046264a30a8 
  webapp/src/test/java/org/apache/atlas/web/integration/DebugMetricsIT.java 3c614d480c50cb0213d3f0b672163f01aea7739e 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java a4d794615f52e9d0e82828b2434539e7ee627f06 
  webapp/src/test/resources/atlas-application.properties 1d45e78f355f38dfcce028f588ee803aff9acbc1 


Diff: https://reviews.apache.org/r/73317/diff/3/

Changes: https://reviews.apache.org/r/73317/diff/2-3/


Testing
-------

Tested on my CDH cluster with flink example wordcount streaming job.


File Attachments
----------------

Screen Shot 2021-04-30 at 12.38.27 AM.png
  https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png


Thanks,

Josh Yeh


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Josh Yeh via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/
-----------------------------------------------------------

(Updated May 14, 2021, 3:03 p.m.)


Review request for atlas, Ashutosh Mestry, Pinal Shah, and Sarath Subramanian.


Repository: atlas


Description
-------

ATLAS-3812: Add schema for Apache Flink


Diffs (updated)
-----

  addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
  dev-support/atlas-docker/scripts/atlas-build.sh e53ebbba98b7392e8b33cd55d2c5caa3628338f6 


Diff: https://reviews.apache.org/r/73317/diff/2/

Changes: https://reviews.apache.org/r/73317/diff/1-2/


Testing
-------

Tested on my CDH cluster with flink example wordcount streaming job.


File Attachments
----------------

Screen Shot 2021-04-30 at 12.38.27 AM.png
  https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png


Thanks,

Josh Yeh


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Josh Yeh via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review222993
-----------------------------------------------------------




addons/models/1000-Hadoop/1110-flink_model.json
Lines 9 (patched)
<https://reviews.apache.org/r/73317/#comment312151>

    With https://github.com/apache/atlas/commit/92fdf29, we need to remove this field


- Josh Yeh


On April 30, 2021, 7:39 a.m., Josh Yeh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> -----------------------------------------------------------
> 
> (Updated April 30, 2021, 7:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -----
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review222974
-----------------------------------------------------------




addons/models/1000-Hadoop/1110-flink_model.json
Lines 2 (patched)
<https://reviews.apache.org/r/73317/#comment312146>

    remove empty entity types - enumDefs, structDefs, classificationDefs, relationshipDefs



addons/models/1000-Hadoop/1110-flink_model.json
Lines 47 (patched)
<https://reviews.apache.org/r/73317/#comment312145>

    parent supertype already contains inputs/outputs as relationship attribute. This will possibly conflict with those attribute. Consider renaming inputs/outputs


- Sarath Subramanian


On April 30, 2021, 12:39 a.m., Josh Yeh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> -----------------------------------------------------------
> 
> (Updated April 30, 2021, 12:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -----
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review222968
-----------------------------------------------------------




addons/models/1000-Hadoop/1110-flink_model.json
Lines 46 (patched)
<https://reviews.apache.org/r/73317/#comment312138>

    Please split this model in 2 different entities. One could be application and other should be process. This will help with rendering of linage and other features.


- Ashutosh Mestry


On April 30, 2021, 7:39 a.m., Josh Yeh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> -----------------------------------------------------------
> 
> (Updated April 30, 2021, 7:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -----
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>


Re: Review Request 73317: ATLAS-3812: Add schema for Apache Flink

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73317/#review222994
-----------------------------------------------------------




addons/models/1000-Hadoop/1110-flink_model.json
Lines 9 (patched)
<https://reviews.apache.org/r/73317/#comment312152>

    no need to remove SuperType Process,
    remove inputs and outputs attributes from attributeDefs since they are inherited from Process Type. https://github.com/apache/atlas/blob/master/addons/models/0000-Area0/0010-base_model.json#L194


- Nixon Rodrigues


On April 30, 2021, 7:39 a.m., Josh Yeh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73317/
> -----------------------------------------------------------
> 
> (Updated April 30, 2021, 7:39 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3812: Add schema for Apache Flink
> 
> 
> Diffs
> -----
> 
>   addons/models/1000-Hadoop/1110-flink_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73317/diff/1/
> 
> 
> Testing
> -------
> 
> Tested on my CDH cluster with flink example wordcount streaming job.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2021-04-30 at 12.38.27 AM.png
>   https://reviews.apache.org/media/uploaded/files/2021/04/30/2ff59445-7237-4be1-a1a0-b6db70bc7827__Screen_Shot_2021-04-30_at_12.38.27_AM.png
> 
> 
> Thanks,
> 
> Josh Yeh
> 
>