You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Nadlinger (JIRA)" <ji...@apache.org> on 2012/06/22 19:52:43 UTC
[jira] [Updated] (THRIFT-1635) D codegen bug for required
non-nullable fields
[ https://issues.apache.org/jira/browse/THRIFT-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Nadlinger updated THRIFT-1635:
------------------------------------
Attachment: 0002-Added-struct-codegen-sanity-tests-directly-to-thrift.patch
0001-Fixed-D-codegen-for-required-non-nullable-fields.patch
> D codegen bug for required non-nullable fields
> ----------------------------------------------
>
> Key: THRIFT-1635
> URL: https://issues.apache.org/jira/browse/THRIFT-1635
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
> Reporter: David Nadlinger
> Priority: Blocker
> Attachments: 0001-Fixed-D-codegen-for-required-non-nullable-fields.patch, 0002-Added-struct-codegen-sanity-tests-directly-to-thrift.patch
>
>
> The attached patches fix handling of structs with non-nullable (as in assignability of {{null}} to their D representation), required fields, and add a simple test case to prevent similar stupid mistakes in the future.
> An actual test case for the functionality should be added to the standalone test site at some point (I was absolutely surprised that this is not covered yet), but I can't spare the time to do so right now, and fixing the issue is critical, as it e.g. breaks the HBase Thrift interface for D.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira