You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2020/03/03 01:12:09 UTC

[isis] branch master updated: ISIS-2296: fixes isisSessionStack removed too early

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new e50d938  ISIS-2296: fixes isisSessionStack removed too early
e50d938 is described below

commit e50d9388678a53201495018cc2fedcc15d89c707
Author: Andi Huber <ah...@apache.org>
AuthorDate: Tue Mar 3 02:11:59 2020 +0100

    ISIS-2296: fixes isisSessionStack removed too early
---
 .../isis/core/runtimeservices/session/IsisSessionFactoryDefault.java  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/core/runtimeservices/src/main/java/org/apache/isis/core/runtimeservices/session/IsisSessionFactoryDefault.java b/core/runtimeservices/src/main/java/org/apache/isis/core/runtimeservices/session/IsisSessionFactoryDefault.java
index fffff7a..adcd7e6 100644
--- a/core/runtimeservices/src/main/java/org/apache/isis/core/runtimeservices/session/IsisSessionFactoryDefault.java
+++ b/core/runtimeservices/src/main/java/org/apache/isis/core/runtimeservices/session/IsisSessionFactoryDefault.java
@@ -213,7 +213,9 @@ public class IsisSessionFactoryDefault implements IsisSessionFactory, IsisSessio
                     runtimeEventService.fireSessionClosing(isisSession); // only fire on top-level session 
                 }
             }
-            isisSessionStack.remove();
+            if(downToStackSize == 0) {
+                isisSessionStack.remove();
+            }
         }
     }