You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2008/04/17 11:36:15 UTC
Re: svn commit: r649000 - in /apr/apr/trunk: include/arch/win32/apr_arch_misc.h
misc/win32/misc.c
mturk@apache.org wrote:
> +++ apr/apr/trunk/include/arch/win32/apr_arch_misc.h Thu Apr 17 01:30:14 2008
> @@ -180,7 +180,7 @@
> DLL_defined = 6 // must define as last idx_ + 1
> } apr_dlltoken_e;
>
> -FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, char *fnName, int ordinal);
> +FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, const char *fnName, int ordinal);
This bit is an API breakage (but not a binary ABI breakage). Hmmm.
I can accept it but thought it should be discussed on list.
Bill
Re: svn commit: r649000 - in /apr/apr/trunk: include/arch/win32/apr_arch_misc.h
misc/win32/misc.c
Posted by Mladen Turk <mt...@apache.org>.
William A. Rowe, Jr. wrote:
> Mladen Turk wrote:
>> William A. Rowe, Jr. wrote:
>>> mturk@apache.org wrote:
>>>> +++ apr/apr/trunk/include/arch/win32/apr_arch_misc.h Thu Apr 17
>>>> 01:30:14 2008
>>>> @@ -180,7 +180,7 @@
>>>> DLL_defined = 6 // must define as last idx_ + 1
>>>> } apr_dlltoken_e;
>>>>
>>>> -FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, char *fnName, int
>>>> ordinal);
>>>> +FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, const char *fnName,
>>>> int ordinal);
>>>
>>> This bit is an API breakage (but not a binary ABI breakage). Hmmm.
>>>
>>> I can accept it but thought it should be discussed on list.
>>>
>>
>> I thought that was apr private, isn't it?
>> It isn't exported as far as I can tell.
>
> ACK - should be no problem. By the way, what compiler was giving you
> errors? I've built as far as VC 2008's compiler and hadn't seen any
> noise here.
>
It's 64 bit compilation that makes warnings, usually conversion
from pointer to DWORD (64 to 32 bit). Fixed now by using
apr_ssize_t when casting.
Regards
--
(TM)
Re: svn commit: r649000 - in /apr/apr/trunk: include/arch/win32/apr_arch_misc.h
misc/win32/misc.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Mladen Turk wrote:
> William A. Rowe, Jr. wrote:
>> mturk@apache.org wrote:
>>> +++ apr/apr/trunk/include/arch/win32/apr_arch_misc.h Thu Apr 17
>>> 01:30:14 2008
>>> @@ -180,7 +180,7 @@
>>> DLL_defined = 6 // must define as last idx_ + 1
>>> } apr_dlltoken_e;
>>>
>>> -FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, char *fnName, int
>>> ordinal);
>>> +FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, const char *fnName,
>>> int ordinal);
>>
>> This bit is an API breakage (but not a binary ABI breakage). Hmmm.
>>
>> I can accept it but thought it should be discussed on list.
>>
>
> I thought that was apr private, isn't it?
> It isn't exported as far as I can tell.
ACK - should be no problem. By the way, what compiler was giving you
errors? I've built as far as VC 2008's compiler and hadn't seen any
noise here.
Bill
Re: svn commit: r649000 - in /apr/apr/trunk: include/arch/win32/apr_arch_misc.h
misc/win32/misc.c
Posted by Mladen Turk <mt...@apache.org>.
William A. Rowe, Jr. wrote:
> mturk@apache.org wrote:
>> +++ apr/apr/trunk/include/arch/win32/apr_arch_misc.h Thu Apr 17
>> 01:30:14 2008
>> @@ -180,7 +180,7 @@
>> DLL_defined = 6 // must define as last idx_ + 1
>> } apr_dlltoken_e;
>>
>> -FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, char *fnName, int
>> ordinal);
>> +FARPROC apr_load_dll_func(apr_dlltoken_e fnLib, const char *fnName,
>> int ordinal);
>
> This bit is an API breakage (but not a binary ABI breakage). Hmmm.
>
> I can accept it but thought it should be discussed on list.
>
I thought that was apr private, isn't it?
It isn't exported as far as I can tell.
Regards
--
(TM)