[GitHub] [couchdb] rnewson commented on a diff in pull request #4769: Replace replicator open_doc_revs kaboom with something more descriptive

["rnewson (via GitHub)" <gi...@apache.org>]

rnewson commented on code in PR #4769:
URL: https://github.com/apache/couchdb/pull/4769#discussion_r1329032807


##########
src/couch_replicator/src/couch_replicator_api_wrap.erl:
##########
@@ -284,7 +284,7 @@ open_doc_revs(#httpdb{retries = 0} = HttpDb, Id, Revs, Options, _Fun, _Acc) ->
         couch_replicator_httpc:full_url(HttpDb, [{path, Path}, {qs, QS}])
     ),
     couch_log:error("Replication crashing because GET ~s failed", [Url]),
-    exit(kaboom);
+    exit(open_doc_revs_failed);

Review Comment:
   it would be neat if we could report at least the most recent _reason_ for the failure (of the last retry) either to the log or in the response body, or both!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org