You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2015/04/03 02:57:53 UTC

[GitHub] spark pull request: [Spark-5068][SQL]Fix bug query data when path ...

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5059#discussion_r27710285
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
    @@ -142,7 +142,46 @@ class HadoopTableReader(
           partitionToDeserializer: Map[HivePartition,
           Class[_ <: Deserializer]],
           filterOpt: Option[PathFilter]): RDD[Row] = {
    -    val hivePartitionRDDs = partitionToDeserializer.map { case (partition, partDeserializer) =>
    +        
    +    // SPARK-5068:get FileStatus and do the filtering locally when the path is not exists
    +    def verifyPartitionPath(
    +        partitionToDeserializer: Map[HivePartition, Class[_ <: Deserializer]]):
    +        Map[HivePartition, Class[_ <: Deserializer]] = {
    +      if (!sc.getConf("spark.sql.hive.verifyPartitionPath", "true").toBoolean) {
    --- End diff --
    
    Can you move this into SQLConf?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org