You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Guillaume Nodet <gn...@apache.org> on 2021/01/19 12:21:28 UTC

Follow-up PR for JUnit 5

I've pushed a PR following up the switch to JUnit 5 which includes two
commits:
  - the use of standard parameterized tests (for speed, I initially reused
the stuff I wrote for Camel which leads to a smoother migration from junit
3/4 parameterized tests, but given there are only 2 test classes using
those, I don't think it's worth maintaining those annotations/extension)
  - the refactor of the PlexusTestCase used as a parent class into a proper
junit 5 extension

The PR is available for review at https://github.com/apache/maven/pull/432

Cheers,
Guillaume Nodet

Re: Follow-up PR for JUnit 5

Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1000 was expected since years (using rule with junit4 before junit5 comes
out) and ease contributions a lot

Thanks a lot Guillaume for all that work

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 19 janv. 2021 à 13:21, Guillaume Nodet <gn...@apache.org> a écrit :

> I've pushed a PR following up the switch to JUnit 5 which includes two
> commits:
>   - the use of standard parameterized tests (for speed, I initially reused
> the stuff I wrote for Camel which leads to a smoother migration from junit
> 3/4 parameterized tests, but given there are only 2 test classes using
> those, I don't think it's worth maintaining those annotations/extension)
>   - the refactor of the PlexusTestCase used as a parent class into a proper
> junit 5 extension
>
> The PR is available for review at https://github.com/apache/maven/pull/432
>
> Cheers,
> Guillaume Nodet
>