You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2020/11/09 13:47:00 UTC

[jira] [Commented] (OMID-166) AbstractTransactionManager.closeResources should be public

    [ https://issues.apache.org/jira/browse/OMID-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228588#comment-17228588 ] 

Istvan Toth commented on OMID-166:
----------------------------------

I could argue that all methods that are not inherited from TransactionManager should be protected, not just closeResources().

> AbstractTransactionManager.closeResources should be public
> ----------------------------------------------------------
>
>                 Key: OMID-166
>                 URL: https://issues.apache.org/jira/browse/OMID-166
>             Project: Phoenix Omid
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>            Reporter: Robert Yokota
>            Assignee: Istvan Toth
>            Priority: Major
>
> AbstractTransactionManager.closeResources is an abstract method that is package private.  It should be made public so that it can be overridden by classes outside of the "org.apache.omid.transaction" package.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)