You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/01/20 05:35:40 UTC

Review Request 42543: Added overloads for `JSON::NumberWriter` and `json` to handle `size_t`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42543/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4435
    https://issues.apache.org/jira/browse/MESOS-4435


Repository: mesos


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp a87b9e2ade68eabd8560470b211a4703f3183d73 

Diff: https://reviews.apache.org/r/42543/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Re: Review Request 42543: Updated `json` to handle integral types comprehensively.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42543/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 4:06 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

Fixed style issues.


Bugs: MESOS-4435
    https://issues.apache.org/jira/browse/MESOS-4435


Repository: mesos


Description (updated)
-------

Updated `json` to handle integral types comprehensively.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp addec8ec6504e2a8f5b838fce3ebd4db224ab022 

Diff: https://reviews.apache.org/r/42543/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Re: Review Request 42543: Updated `json` to handle integral types comprehensively.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42543/#review117155
-----------------------------------------------------------


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 20, 2016, 5:04 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42543/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 5:04 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4435
>     https://issues.apache.org/jira/browse/MESOS-4435
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp a87b9e2ade68eabd8560470b211a4703f3183d73 
> 
> Diff: https://reviews.apache.org/r/42543/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 42543: Updated `json` to handle integral types comprehensively.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42543/
-----------------------------------------------------------

(Updated Jan. 20, 2016, 5:04 p.m.)


Review request for mesos and Benjamin Hindman.


Summary (updated)
-----------------

Updated `json` to handle integral types comprehensively.


Bugs: MESOS-4435
    https://issues.apache.org/jira/browse/MESOS-4435


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp a87b9e2ade68eabd8560470b211a4703f3183d73 

Diff: https://reviews.apache.org/r/42543/diff/


Testing
-------

`make check`


Thanks,

Michael Park