You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by va...@apache.org on 2023/06/19 17:45:25 UTC

[couchdb] branch hack-bypass-histogram-updates updated (3c108b9d5 -> eff37a8ed)

This is an automated email from the ASF dual-hosted git repository.

vatamane pushed a change to branch hack-bypass-histogram-updates
in repository https://gitbox.apache.org/repos/asf/couchdb.git


    omit 3c108b9d5 As a hack to quantify histogram update bottleneck disable histogram updates
     new eff37a8ed As a hack to quantify histogram update bottleneck disable histogram updates

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (3c108b9d5)
            \
             N -- N -- N   refs/heads/hack-bypass-histogram-updates (eff37a8ed)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 Makefile | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)


[couchdb] 01/01: As a hack to quantify histogram update bottleneck disable histogram updates

Posted by va...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

vatamane pushed a commit to branch hack-bypass-histogram-updates
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit eff37a8ed2d87ed05497cef473f52f648f627357
Author: Nick Vatamaniuc <va...@gmail.com>
AuthorDate: Mon Jun 19 11:41:23 2023 -0400

    As a hack to quantify histogram update bottleneck disable histogram updates
    
    !don't merge!
    
    Related to: https://github.com/apache/couchdb-folsom/pull/5
---
 Makefile                            | 13 +++++++------
 src/couch_stats/src/couch_stats.erl |  3 +++
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 1615cac67..2629f7c16 100644
--- a/Makefile
+++ b/Makefile
@@ -152,12 +152,13 @@ escriptize: couch
 .PHONY: check
 # target: check - Test everything
 check: all
-	@$(MAKE) exunit
-	@$(MAKE) eunit
-	@$(MAKE) mango-test
-	@$(MAKE) elixir-suite
-	@$(MAKE) weatherreport-test
-	@$(MAKE) nouveau-test
+	echo "Skip tests"
+	# @$(MAKE) exunit
+	# @$(MAKE) eunit
+	# @$(MAKE) mango-test
+	# @$(MAKE) elixir-suite
+	# @$(MAKE) weatherreport-test
+	# @$(MAKE) nouveau-test
 
 ifdef apps
 subdirs = $(apps)
diff --git a/src/couch_stats/src/couch_stats.erl b/src/couch_stats/src/couch_stats.erl
index e0303fc0f..a1715554f 100644
--- a/src/couch_stats/src/couch_stats.erl
+++ b/src/couch_stats/src/couch_stats.erl
@@ -114,6 +114,9 @@ update_gauge(Name, Value) ->
     notify_existing_metric(Name, Value, gauge).
 
 -spec notify_existing_metric(any(), any(), any()) -> response().
+notify_existing_metric(Name, Op, histogram) ->
+    %% HACK! skip histogram updates for a benchmark
+    ok;
 notify_existing_metric(Name, Op, Type) ->
     try
         ok = folsom_metrics:notify_existing_metric(Name, Op, Type)