[GitHub] [activemq] jbonofre commented on a change in pull request #351: ActiveMQMessageConsumer - do not log whole message including headers in WARN

[GitBox <gi...@apache.org>]

jbonofre commented on a change in pull request #351:
URL: https://github.com/apache/activemq/pull/351#discussion_r599302102



##########
File path: activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageConsumer.java
##########
@@ -1457,7 +1457,7 @@ public void dispatch(MessageDispatch md) {
                             session.getConnection().rollbackDuplicate(this, md.getMessage());
                             dispatch(md);
                         } else {
-                            LOG.warn("{} suppressing duplicate delivery on connection, poison acking: {}", getConsumerId(), md);
+                            LOG.warn("{} suppressing duplicate delivery on connection, poison acking: {}", getConsumerId(), md.getMessage());

Review comment:
       Rethinking about that, I think the whole message can be helpful.
   A poison ack happens when the message redelivery exhausted (for instance, the redelivery count is greater than the limit). Having the whole message, including the headers is helpful to have some clue why the message has been redelivered (it could be related to a bad header for a consumer).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org