You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Liya Fan (JIRA)" <ji...@apache.org> on 2019/06/19 10:20:00 UTC

[jira] [Created] (FLINK-12900) Refactor the class hierarchy for BinaryFormat

Liya Fan created FLINK-12900:
--------------------------------

             Summary: Refactor the class hierarchy for BinaryFormat
                 Key: FLINK-12900
                 URL: https://issues.apache.org/jira/browse/FLINK-12900
             Project: Flink
          Issue Type: Improvement
          Components: Table SQL / Runtime
            Reporter: Liya Fan
            Assignee: Liya Fan


The there are many classes in the class hierarchy of BinaryFormat. They share the same memory format:

header + nullable bits + fixed length part + variable length part

So many operations can be applied to a number of sub-classes. Currently, many such operations are implemented in each sub-class, although they implement identical functionality. 

This makes the code hard to understand and maintain.

In this proposal, we refactor the class hierarchy, and move common operations into the base class, leaving only one implementation for each common operation. 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)