[jira] [Updated] (THRIFT-1177) Update thrift to reflect changes in Go's networking libraries

["Trevor Summers Smith (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Summers Smith updated THRIFT-1177:
-----------------------------------------

    Attachment: gopatch2-r2.diff

The first patch submitted has one bug that prevents the Cassandra thrift file from compiling (http.Get now returns three values and was returning two). I have attached the full patch with this bug fixed.

I used: 6g version release.r57.1 8294 and compiled the Cassandra-0.8.0 Thrift file successfully, and tested some of its basic functionality.

I did not do an in-depth review of all changes in this patch, because I am not yet familiar enough with the codebase.

> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
>                 Key: THRIFT-1177
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1177
>             Project: Thrift
>          Issue Type: Dependency upgrade
>          Components: Go - Compiler, Go - Library
>    Affects Versions: 0.7
>            Reporter: Aalok Shah
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira