You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/05/07 00:15:46 UTC

[GitHub] storm pull request #2655: STORM-3051:some Potential NPEs

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2655#discussion_r186308155
  
    --- Diff: storm-client/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
    @@ -97,9 +97,11 @@ public synchronized static CgroupCenter getInstance() {
         @Override
         public boolean isSubSystemEnabled(SubSystemType subSystemType) {
             Set<SubSystem> subSystems = this.getSubSystems();
    -        for (SubSystem subSystem : subSystems) {
    -            if (subSystem.getType() == subSystemType) {
    -                return true;
    +        if (subSystems != null){
    --- End diff --
    
    nit: space between `)` and `{`


---