You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/01 02:31:47 UTC

Review Request 65852: Added a test to ensure /quota and SET_QUOTA disallow limit.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65852/
-----------------------------------------------------------

Review request for mesos, Michael Park and Meng Zhu.


Repository: mesos


Description
-------

We will only allow limit to be set using UPDATE_QUOTA, this
tests that users cannot specify a limit in the old APIs.


Diffs
-----

  src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69 


Diff: https://reviews.apache.org/r/65852/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Re: Review Request 65852: Added a test to ensure /quota and SET_QUOTA disallow limit.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65852/#review202149
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On Feb. 28, 2018, 6:31 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65852/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2018, 6:31 p.m.)
> 
> 
> Review request for mesos, Michael Park and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We will only allow limit to be set using UPDATE_QUOTA, this
> tests that users cannot specify a limit in the old APIs.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69 
> 
> 
> Diff: https://reviews.apache.org/r/65852/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>