You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Abhitocode (via GitHub)" <gi...@apache.org> on 2024/08/20 14:50:28 UTC
[PR] [incubator-kie-issues-1131] test migration from V7 to code generation-20 [incubator-kie-kogito-runtimes]
Abhitocode opened a new pull request, #3627:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627
In addition to previous changes associated,
Migrated tests within FlowTest.java
The test can be identified by referring to FlowTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/FlowTest.java
Closes https://github.com/apache/incubator-kie-issues/issues/1131.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-20 [incubator-kie-kogito-runtimes]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on code in PR #3627:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627#discussion_r1725137936
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/FlowTest.java:
##########
@@ -1435,15 +1377,19 @@ public void testExclusiveSplitDefaultNoCondition() throws Exception {
}
@Test
- public void testMultipleGatewaysProcess() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/flow/BPMN2-MultipleGatewaysProcess.bpmn2");
- kruntime.getProcessEventManager().addEventListener(new DefaultKogitoProcessEventListener() {
- KogitoProcessInstance pi;
+ public void testMultipleGatewaysProcess() {
+ Application app = ProcessTestHelper.newApplication();
+ org.kie.kogito.process.Process<MultipleGatewaysProcessModel> definition = MultipleGatewaysProcessProcess.newProcess(app);
+ MultipleGatewaysProcessModel model = definition.createModel();
+ model.setAction("CreateAgent");
+
+ ProcessTestHelper.registerProcessEventListener(app, new DefaultKogitoProcessEventListener() {
+ ProcessInstance<MultipleGatewaysProcessModel> pi;
@Override
public void afterNodeTriggered(ProcessNodeTriggeredEvent event) {
if (event.getNodeInstance().getNodeName().equals("CreateAgent")) {
- pi.signalEvent("Signal_1", null);
+ pi.send(Sig.of("Signal_1", null));
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-20 [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3627:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627#issuecomment-2301268692
**PR job** `#2` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/2/display/redirect
**Test results:**
- PASSED: 3353
- FAILED: 3
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/2/testReport/org.jbpm.bpmn2/FlowTest/testMultipleGatewaysProcess/">org.jbpm.bpmn2.FlowTest.testMultipleGatewaysProcess</a></summary>
<br/>expected: 2<br/> but was: 1
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/2/testReport/org.jbpm.bpmn2/IntermediateEventTest/testIntermediateCatchEventTimerCycle3/">org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycle3</a></summary>
<br/>expected: 3<br/> but was: 2
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/2/testReport/org.kie.kogito.process.dynamic/DynamicCallResourceTest/testConcurrentDynamicCalls/">org.kie.kogito.process.dynamic.DynamicCallResourceTest.testConcurrentDynamicCalls</a></summary>
java.lang.AssertionError: 1 expectation failed.<br/>Expected status code <200> but was <400>.<br/>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-20 [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3627:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627#issuecomment-2301172462
**PR job** `#3` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/3/display/redirect
**Test results:**
- PASSED: 3355
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/3/testReport/org.jbpm.bpmn2/FlowTest/testMultipleGatewaysProcess/">org.jbpm.bpmn2.FlowTest.testMultipleGatewaysProcess</a></summary>
<br/>expected: 2<br/> but was: 1
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-20 [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3627:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627#discussion_r1724573046
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/FlowTest.java:
##########
@@ -1435,15 +1377,19 @@ public void testExclusiveSplitDefaultNoCondition() throws Exception {
}
@Test
- public void testMultipleGatewaysProcess() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/flow/BPMN2-MultipleGatewaysProcess.bpmn2");
- kruntime.getProcessEventManager().addEventListener(new DefaultKogitoProcessEventListener() {
- KogitoProcessInstance pi;
+ public void testMultipleGatewaysProcess() {
+ Application app = ProcessTestHelper.newApplication();
+ org.kie.kogito.process.Process<MultipleGatewaysProcessModel> definition = MultipleGatewaysProcessProcess.newProcess(app);
+ MultipleGatewaysProcessModel model = definition.createModel();
+ model.setAction("CreateAgent");
+
+ ProcessTestHelper.registerProcessEventListener(app, new DefaultKogitoProcessEventListener() {
+ ProcessInstance<MultipleGatewaysProcessModel> pi;
@Override
public void afterNodeTriggered(ProcessNodeTriggeredEvent event) {
if (event.getNodeInstance().getNodeName().equals("CreateAgent")) {
- pi.signalEvent("Signal_1", null);
+ pi.send(Sig.of("Signal_1", null));
Review Comment:
use the kruntime in here. not the pi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-20 [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on PR #3627:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627#issuecomment-2301358171
plz be aware of the CI failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-20 [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian merged PR #3627:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-20 [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3627:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627#issuecomment-2303978431
**PR job** `#4` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3627 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/4/display/redirect
**Test results:**
- PASSED: 3355
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3627/4/testReport/org.jbpm.bpmn2/IntermediateEventTest/testEventBasedSplit2/">org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2</a></summary>
<br/>Expected size: 2 but was: 1 in:<br/>[EventDesciption [event=timerTriggered, nodeId=_4, nodeName=timer, eventType=timer, nodeInstanceId=e9261cd5-dcef-4689-9553-feae88c1cbe9, processInstanceId=dc3f100b-5879-4f3d-80d2-854ee09f6cb5, dataType=null, properties={TimerID=c5c33f3b-2355-4c8f-879a-f59c8c7550c8, Period=null, Delay=500ms, Date=null}]]
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org