You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/08 03:07:47 UTC
Review Request 13398: Added checkpointing ability for example frameworks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13398/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-626
https://issues.apache.org/jira/browse/MESOS-626
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/examples/java/TestFramework.java d130b08dd5066da1926cad4e2443f62b50abcc37
src/examples/long_lived_framework.cpp 9c86481eb45cd8cdf923ddad2112a3a9010153b4
src/examples/python/test_framework.py 63725086b58d94cd4e1685f83f7dadbb5dd271f1
src/examples/test_framework.cpp f91d57aedd92c8a3b6e35cc71a2577df9f08665d
Diff: https://reviews.apache.org/r/13398/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13398: Added checkpointing ability for example frameworks.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 8, 2013, 5:28 p.m., Ben Mahler wrote:
> > If someone runs:
> >
> > $ MESOS_CHECKPOINT=0 ./long-lived-framework master
> >
> > This will enable checkpointing? Maybe we should check the value of the environment variable, or try to match what <stout/flags.hpp> does when processing environment variables?
For boolean environment vars, we've used existence of them as signal for 'true'. See MESOS_LOCAL and MESOS_CHECKPOINT in exec.cpp. I would like to stick to that simplicity. Also checkpointing is going to be the default soon, so I don't want make this too sophisticated.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13398/#review24893
-----------------------------------------------------------
On Aug. 8, 2013, 1:07 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13398/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 1:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-626
> https://issues.apache.org/jira/browse/MESOS-626
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java d130b08dd5066da1926cad4e2443f62b50abcc37
> src/examples/long_lived_framework.cpp 9c86481eb45cd8cdf923ddad2112a3a9010153b4
> src/examples/python/test_framework.py 63725086b58d94cd4e1685f83f7dadbb5dd271f1
> src/examples/test_framework.cpp f91d57aedd92c8a3b6e35cc71a2577df9f08665d
>
> Diff: https://reviews.apache.org/r/13398/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13398: Added checkpointing ability for example frameworks.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13398/#review24893
-----------------------------------------------------------
If someone runs:
$ MESOS_CHECKPOINT=0 ./long-lived-framework master
This will enable checkpointing? Maybe we should check the value of the environment variable, or try to match what <stout/flags.hpp> does when processing environment variables?
- Ben Mahler
On Aug. 8, 2013, 1:07 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13398/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 1:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-626
> https://issues.apache.org/jira/browse/MESOS-626
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java d130b08dd5066da1926cad4e2443f62b50abcc37
> src/examples/long_lived_framework.cpp 9c86481eb45cd8cdf923ddad2112a3a9010153b4
> src/examples/python/test_framework.py 63725086b58d94cd4e1685f83f7dadbb5dd271f1
> src/examples/test_framework.cpp f91d57aedd92c8a3b6e35cc71a2577df9f08665d
>
> Diff: https://reviews.apache.org/r/13398/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13398: Added checkpointing ability for example frameworks.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13398/#review24930
-----------------------------------------------------------
Ship it!
I'd prefer command line flags, but that's probably a wasted effort given you'll be removing this anyway. Looks good!
- Ben Mahler
On Aug. 8, 2013, 1:07 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13398/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 1:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-626
> https://issues.apache.org/jira/browse/MESOS-626
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java d130b08dd5066da1926cad4e2443f62b50abcc37
> src/examples/long_lived_framework.cpp 9c86481eb45cd8cdf923ddad2112a3a9010153b4
> src/examples/python/test_framework.py 63725086b58d94cd4e1685f83f7dadbb5dd271f1
> src/examples/test_framework.cpp f91d57aedd92c8a3b6e35cc71a2577df9f08665d
>
> Diff: https://reviews.apache.org/r/13398/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>