You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/01/02 08:44:26 UTC
[PR] [SPARK-46564][PYTHON][INFRA] Exclude unrelated files via using omit options properly in PySpark coverage report [spark]
HyukjinKwon opened a new pull request, #44559:
URL: https://github.com/apache/spark/pull/44559
### What changes were proposed in this pull request?
This PR proposes to remove 3rd party or generated files from PySpark test coverage report by using the proper syntax for `--omit` supported by `coverage` command. `--omit="pyspark/..." --omit=...` used to work but seems it doesn't work anymore in newer versions.
### Why are the changes needed?
The files are not excluded for some reasons at the PySpark test coverage report (https://app.codecov.io/gh/apache/spark)
We should exclude unrelated files.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Manually tested via:
```
./run-tests-with-coverage --python-executables=python3 --testname="pyspark.sql.dataframe"
```
checked those files are not reported:
```
Reporting the coverage data at /.../spark/python/test_coverage/coverage_data/coverage
Name Stmts Miss Branch BrPart Cover
-------------------------------------------------------------------------
pyspark/__init__.py 48 7 10 3 76%
pyspark/_globals.py 16 3 4 2 75%
pyspark/accumulators.py 121 44 26 5 61%
pyspark/broadcast.py 121 79 40 3 33%
...
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46564][PYTHON][INFRA] Exclude unrelated files via using omit options properly in PySpark coverage report [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44559: [SPARK-46564][PYTHON][INFRA] Exclude unrelated files via using omit options properly in PySpark coverage report
URL: https://github.com/apache/spark/pull/44559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46564][PYTHON][INFRA] Exclude unrelated files via using omit options properly in PySpark coverage report [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44559:
URL: https://github.com/apache/spark/pull/44559#issuecomment-1873743381
Build: https://github.com/HyukjinKwon/spark/actions/runs/7383650495/job/20085236976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org