You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ni...@apache.org on 2014/04/24 17:07:21 UTC
svn commit: r1589765 - in /poi/trunk/src/ooxml/java/org/apache/poi:
extractor/ExtractorFactory.java xslf/extractor/XSLFPowerPointExtractor.java
xssf/dev/XSSFDump.java xssf/eventusermodel/ReadOnlySharedStringsTable.java
Author: nick
Date: Thu Apr 24 15:07:20 2014
New Revision: 1589765
URL: http://svn.apache.org/r1589765
Log:
Fix some Eclipse identified warnings
Modified:
poi/trunk/src/ooxml/java/org/apache/poi/extractor/ExtractorFactory.java
poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/dev/XSSFDump.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/ReadOnlySharedStringsTable.java
Modified: poi/trunk/src/ooxml/java/org/apache/poi/extractor/ExtractorFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/extractor/ExtractorFactory.java?rev=1589765&r1=1589764&r2=1589765&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/extractor/ExtractorFactory.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/extractor/ExtractorFactory.java Thu Apr 24 15:07:20 2014
@@ -200,7 +200,6 @@ public class ExtractorFactory {
* @deprecated Use {@link #createExtractor(DirectoryNode)} instead
*/
@Deprecated
- @SuppressWarnings("unused")
public static POITextExtractor createExtractor(DirectoryNode poifsDir, POIFSFileSystem fs)
throws IOException, InvalidFormatException, OpenXML4JException, XmlException
{
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java?rev=1589765&r1=1589764&r2=1589765&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java Thu Apr 24 15:07:20 2014
@@ -71,6 +71,7 @@ public class XSLFPowerPointExtractor ext
new XSLFPowerPointExtractor(
new XSLFSlideShow(args[0]));
System.out.println(extractor.getText());
+ extractor.close();
}
/**
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/dev/XSSFDump.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/dev/XSSFDump.java?rev=1589765&r1=1589764&r2=1589765&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/dev/XSSFDump.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/dev/XSSFDump.java Thu Apr 24 15:07:20 2014
@@ -17,14 +17,18 @@
package org.apache.poi.xssf.dev;
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.Enumeration;
+import java.util.zip.ZipEntry;
+import java.util.zip.ZipFile;
+
import org.apache.xmlbeans.XmlObject;
import org.apache.xmlbeans.XmlOptions;
-import java.io.*;
-import java.util.zip.ZipFile;
-import java.util.zip.ZipEntry;
-import java.util.Enumeration;
-
/**
* Utility class which dumps the contents of a *.xlsx file into file system.
*
@@ -46,9 +50,9 @@ public final class XSSFDump {
File root = new File(zipname.substring(0, sep));
root.mkdir();
- Enumeration en = zip.entries();
+ Enumeration<? extends ZipEntry> en = zip.entries();
while(en.hasMoreElements()){
- ZipEntry entry = (ZipEntry)en.nextElement();
+ ZipEntry entry = en.nextElement();
String name = entry.getName();
int idx = name.lastIndexOf('/');
if(idx != -1){
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/ReadOnlySharedStringsTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/ReadOnlySharedStringsTable.java?rev=1589765&r1=1589764&r2=1589765&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/ReadOnlySharedStringsTable.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/ReadOnlySharedStringsTable.java Thu Apr 24 15:07:20 2014
@@ -29,7 +29,6 @@ import org.apache.poi.openxml4j.opc.OPCP
import org.apache.poi.openxml4j.opc.PackagePart;
import org.apache.poi.openxml4j.opc.PackageRelationship;
import org.apache.poi.xssf.usermodel.XSSFRelation;
-import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTRst;
import org.xml.sax.Attributes;
import org.xml.sax.InputSource;
import org.xml.sax.SAXException;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org