[jira] [Commented] (HBASE-8006) use FSUtils to get/set hbase.rootdir

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593500#comment-13593500 ] 

Hadoop QA commented on HBASE-8006:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12572097/HBASE-8006-v0.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 48 new or modified tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.catalog.TestMetaMigrationConvertingToPB
                  org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed
                  org.apache.hadoop.hbase.replication.TestReplicationQueueFailover
                  org.apache.hadoop.hbase.master.TestMasterFailover

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4670//console

This message is automatically generated.
                
> use FSUtils to get/set hbase.rootdir
> ------------------------------------
>
>                 Key: HBASE-8006
>                 URL: https://issues.apache.org/jira/browse/HBASE-8006
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>              Labels: noob
>         Attachments: HBASE-8006-v0.patch
>
>
> We have different ways around the code to get the root dir
> {code}
> this.conf.get("hbase.rootdir")
> new Path(conf.get(HConstants.HBASE_DIR));
> fs.makeQualified(new Path(this.c.get(HConstants.HBASE_DIR)));
> FSUtils.getRootDir(conf)
> {code}
> also we have lots of places where we have this set fs.default
> {code}
> this.conf.set("fs.default.name", fs.getUri().toString());
> this.conf.set("fs.defaultFS", fs.getUri().toString());
> {code}
> replace everything to use the FSUtils and have one single way to do this stuff

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira