You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by ztao1987 <gi...@git.apache.org> on 2016/02/05 08:04:11 UTC
[GitHub] incubator-hawq pull request: HAWQ-402. Fix bug that core dump due ...
GitHub user ztao1987 opened a pull request:
https://github.com/apache/incubator-hawq/pull/335
HAWQ-402. Fix bug that core dump due to nullptr in GroupClause
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ztao1987/incubator-hawq HAWQ-402
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/335.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #335
----
commit 858df7315a0a5518e9aa0aecacb6f342f1bfc43b
Author: zhenglin tao <zh...@gmail.com>
Date: 2016-02-05T07:02:11Z
HAWQ-402. Fix bug that core dump due to nullptr in GroupClause
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-402. Fix bug that core dump due ...
Posted by ztao1987 <gi...@git.apache.org>.
Github user ztao1987 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/335#discussion_r52875973
--- Diff: src/backend/optimizer/util/tlist.c ---
@@ -317,6 +317,10 @@ get_sortgrouplist_exprs(List *sortClauses, List *targetList)
SortClause *sortcl = (SortClause *) lfirst(l);
Node *sortexpr;
+ // if GroupClause in grouping sets is null,
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-402. Fix bug that core dump due ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/335#issuecomment-184130178
The overall fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-402. Fix bug that core dump due ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/335#discussion_r52875689
--- Diff: src/backend/optimizer/util/tlist.c ---
@@ -317,6 +317,10 @@ get_sortgrouplist_exprs(List *sortClauses, List *targetList)
SortClause *sortcl = (SortClause *) lfirst(l);
Node *sortexpr;
+ // if GroupClause in grouping sets is null,
--- End diff --
Use /* ... */ for line or multiple line comment instead of //
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-402. Fix bug that core dump due ...
Posted by ztao1987 <gi...@git.apache.org>.
Github user ztao1987 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---