You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/10 13:03:43 UTC

[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #680: [LOG4J2-3326] Fix parsing filters from Log4j 1.2 properties configuration file

garydgregory edited a comment on pull request #680:
URL: https://github.com/apache/logging-log4j2/pull/680#issuecomment-1007372996


   Hi @benjaminr-ps 
   
   Thank you for your PR. Would you add a test, please? 
   
   Without a test, there is no way to see that this fixes anything or that undoing the fix would break anything (a regression).
   
   See PropertiesConfigurationTest for an example.
   TY!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org