You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Krista Baker (JIRA)" <be...@incubator.apache.org> on 2005/06/29 23:37:00 UTC

[jira] Created: (BEEHIVE-841) leading blank line in a netui:textArea is removed

leading blank line in a netui:textArea is removed
-------------------------------------------------

         Key: BEEHIVE-841
         URL: http://issues.apache.org/jira/browse/BEEHIVE-841
     Project: Beehive
        Type: Bug
  Components: NetUI  
    Versions: v1m1, V1Beta, V1Alpha    
    Reporter: Krista Baker
 Assigned to: Carlin Rogers 
     Fix For: V1


When the netui:textarea contains blank line(s) in the beginning, the first blank line always gets removed.

I will attach a repro app.  
Repro Description:  Takes input from a text area and outputs it into another text area. If the first line from the input is a blank line then a carriage return is output after the textArea rendering and continue on with the text.  The blank line should be included in the rendered text area.

Visual description:
Enter the following into the first textbox: "\nMyText" (where \n is a return or the input from the datasource)
Click Submit / Next Action
Expected output of the second textbox: 
<textArea>

MyText</textArea>

Actual output in the second textbox: 
<textArea>
MyText</textArea>

The reason is the first \n is used as the return after the textArea tag instead of including the \n at the end of the rendered text area start tag.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (BEEHIVE-841) leading blank line in a netui:textArea is removed

Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-841?page=all ]

Carlin Rogers updated BEEHIVE-841:
----------------------------------

    Attachment: j841-patch.txt

The patch file, j841-patch.txt, contains a fix for the bug, the new BVT based from the repro case from
Krista (thanks!), and updates to other test recordings.

I put the fix into the TextArea.doEndTag() method rather than TextAreaTag.doStartTag(). I only append
the "\n" string if the content to go between the rendered "textarea" HTML elements is not null. If the
content is null, then we just leave the rendered tags as <textarea...></textarea>, rather than write
the closing tag on a newline.

> leading blank line in a netui:textArea is removed
> -------------------------------------------------
>
>          Key: BEEHIVE-841
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-841
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: v1m1, V1Beta, V1Alpha
>     Reporter: Krista Baker
>     Assignee: Carlin Rogers
>      Fix For: V1
>  Attachments: Controller.jpf, index.jsp, j841-patch.txt, result.jsp
>
> When the netui:textarea contains blank line(s) in the beginning, the first blank line always gets removed.
> I will attach a repro app.  
> Repro Description:  Takes input from a text area and outputs it into another text area. If the first line from the input is a blank line then a carriage return is output after the textArea rendering and continue on with the text.  The blank line should be included in the rendered text area.
> Visual description:
> Enter the following into the first textbox: "\nMyText" (where \n is a return or the input from the datasource)
> Click Submit / Next Action
> Expected output of the second textbox: 
> <textArea>
> MyText</textArea>
> Actual output in the second textbox: 
> <textArea>
> MyText</textArea>
> The reason is the first \n is used as the return after the textArea tag instead of including the \n at the end of the rendered text area start tag.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (BEEHIVE-841) leading blank line in a netui:textArea is removed

Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-841?page=all ]
     
Rich Feit resolved BEEHIVE-841:
-------------------------------

    Resolution: Fixed
     Assign To: Krista Baker  (was: Rich Feit)

Applied the patch with revision 208789.

> leading blank line in a netui:textArea is removed
> -------------------------------------------------
>
>          Key: BEEHIVE-841
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-841
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: v1m1, V1Beta, V1Alpha
>     Reporter: Krista Baker
>     Assignee: Krista Baker
>      Fix For: V1
>  Attachments: Controller.jpf, index.jsp, j841-patch.txt, result.jsp
>
> When the netui:textarea contains blank line(s) in the beginning, the first blank line always gets removed.
> I will attach a repro app.  
> Repro Description:  Takes input from a text area and outputs it into another text area. If the first line from the input is a blank line then a carriage return is output after the textArea rendering and continue on with the text.  The blank line should be included in the rendered text area.
> Visual description:
> Enter the following into the first textbox: "\nMyText" (where \n is a return or the input from the datasource)
> Click Submit / Next Action
> Expected output of the second textbox: 
> <textArea>
> MyText</textArea>
> Actual output in the second textbox: 
> <textArea>
> MyText</textArea>
> The reason is the first \n is used as the return after the textArea tag instead of including the \n at the end of the rendered text area start tag.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (BEEHIVE-841) leading blank line in a netui:textArea is removed

Posted by "Carlin Rogers (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-841?page=all ]

Carlin Rogers reassigned BEEHIVE-841:
-------------------------------------

    Assign To: Rich Feit  (was: Carlin Rogers)

Rich, could you please review the patch,j841-patch.txt, and add it for v1.
Thanks,
Carlin

> leading blank line in a netui:textArea is removed
> -------------------------------------------------
>
>          Key: BEEHIVE-841
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-841
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: v1m1, V1Beta, V1Alpha
>     Reporter: Krista Baker
>     Assignee: Rich Feit
>      Fix For: V1
>  Attachments: Controller.jpf, index.jsp, j841-patch.txt, result.jsp
>
> When the netui:textarea contains blank line(s) in the beginning, the first blank line always gets removed.
> I will attach a repro app.  
> Repro Description:  Takes input from a text area and outputs it into another text area. If the first line from the input is a blank line then a carriage return is output after the textArea rendering and continue on with the text.  The blank line should be included in the rendered text area.
> Visual description:
> Enter the following into the first textbox: "\nMyText" (where \n is a return or the input from the datasource)
> Click Submit / Next Action
> Expected output of the second textbox: 
> <textArea>
> MyText</textArea>
> Actual output in the second textbox: 
> <textArea>
> MyText</textArea>
> The reason is the first \n is used as the return after the textArea tag instead of including the \n at the end of the rendered text area start tag.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (BEEHIVE-841) leading blank line in a netui:textArea is removed

Posted by "Krista Baker (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-841?page=all ]
     
Krista Baker closed BEEHIVE-841:
--------------------------------


Verified that leading empty lines before text are no longer removed from a netui:textArea tag.

> leading blank line in a netui:textArea is removed
> -------------------------------------------------
>
>          Key: BEEHIVE-841
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-841
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: v1m1, V1Beta, V1Alpha
>     Reporter: Krista Baker
>     Assignee: Krista Baker
>      Fix For: V1
>  Attachments: Controller.jpf, index.jsp, j841-patch.txt, result.jsp
>
> When the netui:textarea contains blank line(s) in the beginning, the first blank line always gets removed.
> I will attach a repro app.  
> Repro Description:  Takes input from a text area and outputs it into another text area. If the first line from the input is a blank line then a carriage return is output after the textArea rendering and continue on with the text.  The blank line should be included in the rendered text area.
> Visual description:
> Enter the following into the first textbox: "\nMyText" (where \n is a return or the input from the datasource)
> Click Submit / Next Action
> Expected output of the second textbox: 
> <textArea>
> MyText</textArea>
> Actual output in the second textbox: 
> <textArea>
> MyText</textArea>
> The reason is the first \n is used as the return after the textArea tag instead of including the \n at the end of the rendered text area start tag.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (BEEHIVE-841) leading blank line in a netui:textArea is removed

Posted by "Krista Baker (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-841?page=all ]

Krista Baker updated BEEHIVE-841:
---------------------------------

    Attachment: Controller.jpf
                index.jsp
                result.jsp

> leading blank line in a netui:textArea is removed
> -------------------------------------------------
>
>          Key: BEEHIVE-841
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-841
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: v1m1, V1Beta, V1Alpha
>     Reporter: Krista Baker
>     Assignee: Carlin Rogers
>      Fix For: V1
>  Attachments: Controller.jpf, index.jsp, result.jsp
>
> When the netui:textarea contains blank line(s) in the beginning, the first blank line always gets removed.
> I will attach a repro app.  
> Repro Description:  Takes input from a text area and outputs it into another text area. If the first line from the input is a blank line then a carriage return is output after the textArea rendering and continue on with the text.  The blank line should be included in the rendered text area.
> Visual description:
> Enter the following into the first textbox: "\nMyText" (where \n is a return or the input from the datasource)
> Click Submit / Next Action
> Expected output of the second textbox: 
> <textArea>
> MyText</textArea>
> Actual output in the second textbox: 
> <textArea>
> MyText</textArea>
> The reason is the first \n is used as the return after the textArea tag instead of including the \n at the end of the rendered text area start tag.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira