You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/03/20 12:15:24 UTC

Review Request 32297: Add Mahout to HDP Stack

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.


Bugs: AMBARI-9994
    https://issues.apache.org/jira/browse/AMBARI-9994


Repository: ambari


Description
-------

.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
  ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 

Diff: https://reviews.apache.org/r/32297/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 32297: Add Mahout to HDP Stack

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On March 20, 2015, 11:31 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py, line 30
> > <https://reviews.apache.org/r/32297/diff/1/?file=901314#file901314line30>
> >
> >     Let's create tez_user, maybe we don't need this now but looking into future it might be useful
> 
> Jeff Sposetti wrote:
>     Just mentioning. Ambari already prompts for a tez user (so it can be customized). If you need a tez user, be sure that we don't end up with two that could deviate.

I meant mahout_user, it's a typo ;)


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/#review77201
-----------------------------------------------------------


On March 20, 2015, 11:15 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32297/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:15 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9994
>     https://issues.apache.org/jira/browse/AMBARI-9994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32297/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 32297: Add Mahout to HDP Stack

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On March 20, 2015, 11:31 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py, line 30
> > <https://reviews.apache.org/r/32297/diff/1/?file=901314#file901314line30>
> >
> >     Let's create tez_user, maybe we don't need this now but looking into future it might be useful
> 
> Jeff Sposetti wrote:
>     Just mentioning. Ambari already prompts for a tez user (so it can be customized). If you need a tez user, be sure that we don't end up with two that could deviate.
> 
> Andrew Onischuk wrote:
>     I meant mahout_user, it's a typo ;)
> 
> Jeff Sposetti wrote:
>     Alrighty. :0 Then please confirm sure it makes it all the way to UI and is customizable by the user.

k sure


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/#review77201
-----------------------------------------------------------


On March 20, 2015, 11:15 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32297/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:15 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9994
>     https://issues.apache.org/jira/browse/AMBARI-9994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32297/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 32297: Add Mahout to HDP Stack

Posted by Jeff Sposetti <je...@hortonworks.com>.

> On March 20, 2015, 11:31 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py, line 30
> > <https://reviews.apache.org/r/32297/diff/1/?file=901314#file901314line30>
> >
> >     Let's create tez_user, maybe we don't need this now but looking into future it might be useful
> 
> Jeff Sposetti wrote:
>     Just mentioning. Ambari already prompts for a tez user (so it can be customized). If you need a tez user, be sure that we don't end up with two that could deviate.
> 
> Andrew Onischuk wrote:
>     I meant mahout_user, it's a typo ;)

Alrighty. :0 Then please confirm sure it makes it all the way to UI and is customizable by the user.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/#review77201
-----------------------------------------------------------


On March 20, 2015, 11:15 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32297/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:15 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9994
>     https://issues.apache.org/jira/browse/AMBARI-9994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32297/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 32297: Add Mahout to HDP Stack

Posted by Jeff Sposetti <je...@hortonworks.com>.

> On March 20, 2015, 11:31 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py, line 30
> > <https://reviews.apache.org/r/32297/diff/1/?file=901314#file901314line30>
> >
> >     Let's create tez_user, maybe we don't need this now but looking into future it might be useful

Just mentioning. Ambari already prompts for a tez user (so it can be customized). If you need a tez user, be sure that we don't end up with two that could deviate.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/#review77201
-----------------------------------------------------------


On March 20, 2015, 11:15 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32297/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:15 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9994
>     https://issues.apache.org/jira/browse/AMBARI-9994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32297/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 32297: Add Mahout to HDP Stack

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/#review77201
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py
<https://reviews.apache.org/r/32297/#comment125086>

    Let's create tez_user, maybe we don't need this now but looking into future it might be useful



ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
<https://reviews.apache.org/r/32297/#comment125085>

    We should execute this as sudo else it will fail as non-root user.



ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
<https://reviews.apache.org/r/32297/#comment125087>

    remove_output_dir_cmd = format("fs -rm -r -f /user/{smokeuser}/mahoutsmokeoutput")
    remove_input_dir_cmd = format("fs -rm -r -f /user/{smokeuser}/mahoutsmokeinput")
    
    Can we please change this to
    
    remove_dirs = format("fs -rm -r -f /user/{smokeuser}/mahoutsmokeoutput /user/{smokeuser}/mahoutsmokeinput")
    
    that will make the service check work a bit faster ~15-30 seconds on a hardly loaded cluster


- Andrew Onischuk


On March 20, 2015, 11:15 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32297/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:15 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9994
>     https://issues.apache.org/jira/browse/AMBARI-9994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32297/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 32297: Add Mahout to HDP Stack

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/#review77200
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 20, 2015, 11:15 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32297/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:15 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9994
>     https://issues.apache.org/jira/browse/AMBARI-9994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32297/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 32297: Add Mahout to HDP Stack

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/#review77219
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On March 20, 2015, 2:48 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32297/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 2:48 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-9994
>     https://issues.apache.org/jira/browse/AMBARI-9994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32297/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 32297: Add Mahout to HDP Stack

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32297/
-----------------------------------------------------------

(Updated Березень 20, 2015, 2:48 після полудня)


Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.


Bugs: AMBARI-9994
    https://issues.apache.org/jira/browse/AMBARI-9994


Repository: ambari


Description
-------

.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/Role.java 59ae001 
  ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java b9d2d0c 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/MAHOUT/metainfo.xml PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/configs/default.json PRE-CREATION 

Diff: https://reviews.apache.org/r/32297/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi