You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2005/09/21 01:43:02 UTC

svn commit: r290585 - /myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlLinkRendererBase.java

Author: mmarinschek
Date: Tue Sep 20 16:42:57 2005
New Revision: 290585

URL: http://svn.apache.org/viewcvs?rev=290585&view=rev
Log:
fix for MYFACES-410 - thanks for patch by Zhong Li

Modified:
    myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlLinkRendererBase.java

Modified: myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlLinkRendererBase.java
URL: http://svn.apache.org/viewcvs/myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlLinkRendererBase.java?rev=290585&r1=290584&r2=290585&view=diff
==============================================================================
--- myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlLinkRendererBase.java (original)
+++ myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlLinkRendererBase.java Tue Sep 20 16:42:57 2005
@@ -284,11 +284,11 @@
         }
 
 		// onSubmit
-		onClick.append("if("+jsForm+".onsubmit){"+jsForm+".onsubmit();}");
+        onClick.append("if(").append(jsForm).append(".onsubmit){if(").append(jsForm).append(".onsubmit()) "+jsForm+".submit();}else{");
 
         //submit
         onClick.append(jsForm);
-        onClick.append(".submit();return false;");  //return false, so that browser does not handle the click
+        onClick.append(".submit();}return false;");  //return false, so that browser does not handle the click
 
         writer.startElement(HTML.ANCHOR_ELEM, component);
         writer.writeURIAttribute(HTML.HREF_ATTR, "#", null);