You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Mark Struberg <st...@yahoo.de.INVALID> on 2017/08/15 11:19:28 UTC
[DISCUSS] Release OWB-2.0.1 ?
Hi folks!
I'd love to fix OWB-1209 and get Johns SE changes in.
I think we are then ready to roll a 2.0.1 release, isn't?
John, I'll be available on IRC to coordinate and review your proposed SE changes.
Of course we could also discuss it via IRC, but might be easier to give that feedback via a shared hangout screen.
LieGrue,
strub
.
Re: [DISCUSS] Release OWB-2.0.1 ?
Posted by "John D. Ament" <jo...@apache.org>.
Ok, both tickets are in.
On Wed, Aug 16, 2017 at 12:17 AM Mark Struberg <st...@yahoo.de.invalid>
wrote:
> That would be really great if you could create Tickets and attach patches,
> txs John
>
> LieGrue,
> strub
>
>
> > Am 16.08.2017 um 01:25 schrieb John D. Ament <jo...@apache.org>:
> >
> > A 2.0.1 based on the current would be good, however I would recommend
> > bringing in these two commits independent of the remaining work, since
> they
> > fix core issues.
> >
> > - OWB isn't firing a before destroyed event -
> >
> https://github.com/johnament/openwebbeans/commit/10d62fca523f60a88616b8828cf4efccd845fadc
> > - OWB isn't honoring javax.enterprise.inject.scan.implicit flags -
> >
> https://github.com/johnament/openwebbeans/commit/696e4ba168124ac089e98392bf65c09fe002749d
> >
> > If you want I can create tickets and attach specific patches to those
> > tickets.
> >
> > John
> >
> > On Tue, Aug 15, 2017 at 3:22 PM Romain Manni-Bucau <
> rmannibucau@gmail.com>
> > wrote:
> >
> >> +1 for se in 2.0.2 and 2.0.1 sooner
> >>
> >> If you nees help for SE on something specific, feel free to ping me.
> >>
> >> Le 15 août 2017 14:37, "Mark Struberg" <st...@yahoo.de.invalid> a
> >> écrit :
> >>
> >>> Oki, that seems to be a bit more work to be left still.
> >>>
> >>> I'd then suggest to go on with the immanent features and release
> >> OWB-2.0.1
> >>> pretty soon while targetting 2.0.2 for the SE work.
> >>>
> >>> txs and LieGrue,
> >>> strub
> >>>
> >>>
> >>>> Am 15.08.2017 um 13:48 schrieb John D. Ament <jo...@apache.org>:
> >>>>
> >>>> Mark,
> >>>>
> >>>> SE support is still a long ways from being done. Most of the issues
> >> are
> >>>> resolved, all of the remaining problems are related to OWB not
> honoring
> >>>> when the container's been shutdown.
> >>>>
> >>>> The good news, by removing the automatic starting of request context
> >> and
> >>>> properly shutting down app context in the SELifeCycle class, OWB is
> >>> finally
> >>>> marking the proxies as invalid, but it seems like we still need to add
> >> an
> >>>> isRunning check somewhere.
> >>>>
> >>>> John
> >>>>
> >>>> On Tue, Aug 15, 2017 at 7:19 AM Mark Struberg
> >> <struberg@yahoo.de.invalid
> >>>>
> >>>> wrote:
> >>>>
> >>>>> Hi folks!
> >>>>>
> >>>>> I'd love to fix OWB-1209 and get Johns SE changes in.
> >>>>> I think we are then ready to roll a 2.0.1 release, isn't?
> >>>>>
> >>>>> John, I'll be available on IRC to coordinate and review your proposed
> >> SE
> >>>>> changes.
> >>>>> Of course we could also discuss it via IRC, but might be easier to
> >> give
> >>>>> that feedback via a shared hangout screen.
> >>>>>
> >>>>> LieGrue,
> >>>>> strub
> >>>>> .
> >>>>>
> >>>
> >>>
> >>
>
>
Re: [DISCUSS] Release OWB-2.0.1 ?
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
That would be really great if you could create Tickets and attach patches, txs John
LieGrue,
strub
> Am 16.08.2017 um 01:25 schrieb John D. Ament <jo...@apache.org>:
>
> A 2.0.1 based on the current would be good, however I would recommend
> bringing in these two commits independent of the remaining work, since they
> fix core issues.
>
> - OWB isn't firing a before destroyed event -
> https://github.com/johnament/openwebbeans/commit/10d62fca523f60a88616b8828cf4efccd845fadc
> - OWB isn't honoring javax.enterprise.inject.scan.implicit flags -
> https://github.com/johnament/openwebbeans/commit/696e4ba168124ac089e98392bf65c09fe002749d
>
> If you want I can create tickets and attach specific patches to those
> tickets.
>
> John
>
> On Tue, Aug 15, 2017 at 3:22 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>> +1 for se in 2.0.2 and 2.0.1 sooner
>>
>> If you nees help for SE on something specific, feel free to ping me.
>>
>> Le 15 août 2017 14:37, "Mark Struberg" <st...@yahoo.de.invalid> a
>> écrit :
>>
>>> Oki, that seems to be a bit more work to be left still.
>>>
>>> I'd then suggest to go on with the immanent features and release
>> OWB-2.0.1
>>> pretty soon while targetting 2.0.2 for the SE work.
>>>
>>> txs and LieGrue,
>>> strub
>>>
>>>
>>>> Am 15.08.2017 um 13:48 schrieb John D. Ament <jo...@apache.org>:
>>>>
>>>> Mark,
>>>>
>>>> SE support is still a long ways from being done. Most of the issues
>> are
>>>> resolved, all of the remaining problems are related to OWB not honoring
>>>> when the container's been shutdown.
>>>>
>>>> The good news, by removing the automatic starting of request context
>> and
>>>> properly shutting down app context in the SELifeCycle class, OWB is
>>> finally
>>>> marking the proxies as invalid, but it seems like we still need to add
>> an
>>>> isRunning check somewhere.
>>>>
>>>> John
>>>>
>>>> On Tue, Aug 15, 2017 at 7:19 AM Mark Struberg
>> <struberg@yahoo.de.invalid
>>>>
>>>> wrote:
>>>>
>>>>> Hi folks!
>>>>>
>>>>> I'd love to fix OWB-1209 and get Johns SE changes in.
>>>>> I think we are then ready to roll a 2.0.1 release, isn't?
>>>>>
>>>>> John, I'll be available on IRC to coordinate and review your proposed
>> SE
>>>>> changes.
>>>>> Of course we could also discuss it via IRC, but might be easier to
>> give
>>>>> that feedback via a shared hangout screen.
>>>>>
>>>>> LieGrue,
>>>>> strub
>>>>> .
>>>>>
>>>
>>>
>>
Re: [DISCUSS] Release OWB-2.0.1 ?
Posted by "John D. Ament" <jo...@apache.org>.
A 2.0.1 based on the current would be good, however I would recommend
bringing in these two commits independent of the remaining work, since they
fix core issues.
- OWB isn't firing a before destroyed event -
https://github.com/johnament/openwebbeans/commit/10d62fca523f60a88616b8828cf4efccd845fadc
- OWB isn't honoring javax.enterprise.inject.scan.implicit flags -
https://github.com/johnament/openwebbeans/commit/696e4ba168124ac089e98392bf65c09fe002749d
If you want I can create tickets and attach specific patches to those
tickets.
John
On Tue, Aug 15, 2017 at 3:22 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> +1 for se in 2.0.2 and 2.0.1 sooner
>
> If you nees help for SE on something specific, feel free to ping me.
>
> Le 15 août 2017 14:37, "Mark Struberg" <st...@yahoo.de.invalid> a
> écrit :
>
> > Oki, that seems to be a bit more work to be left still.
> >
> > I'd then suggest to go on with the immanent features and release
> OWB-2.0.1
> > pretty soon while targetting 2.0.2 for the SE work.
> >
> > txs and LieGrue,
> > strub
> >
> >
> > > Am 15.08.2017 um 13:48 schrieb John D. Ament <jo...@apache.org>:
> > >
> > > Mark,
> > >
> > > SE support is still a long ways from being done. Most of the issues
> are
> > > resolved, all of the remaining problems are related to OWB not honoring
> > > when the container's been shutdown.
> > >
> > > The good news, by removing the automatic starting of request context
> and
> > > properly shutting down app context in the SELifeCycle class, OWB is
> > finally
> > > marking the proxies as invalid, but it seems like we still need to add
> an
> > > isRunning check somewhere.
> > >
> > > John
> > >
> > > On Tue, Aug 15, 2017 at 7:19 AM Mark Struberg
> <struberg@yahoo.de.invalid
> > >
> > > wrote:
> > >
> > >> Hi folks!
> > >>
> > >> I'd love to fix OWB-1209 and get Johns SE changes in.
> > >> I think we are then ready to roll a 2.0.1 release, isn't?
> > >>
> > >> John, I'll be available on IRC to coordinate and review your proposed
> SE
> > >> changes.
> > >> Of course we could also discuss it via IRC, but might be easier to
> give
> > >> that feedback via a shared hangout screen.
> > >>
> > >> LieGrue,
> > >> strub
> > >> .
> > >>
> >
> >
>
Re: [DISCUSS] Release OWB-2.0.1 ?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1 for se in 2.0.2 and 2.0.1 sooner
If you nees help for SE on something specific, feel free to ping me.
Le 15 août 2017 14:37, "Mark Struberg" <st...@yahoo.de.invalid> a écrit :
> Oki, that seems to be a bit more work to be left still.
>
> I'd then suggest to go on with the immanent features and release OWB-2.0.1
> pretty soon while targetting 2.0.2 for the SE work.
>
> txs and LieGrue,
> strub
>
>
> > Am 15.08.2017 um 13:48 schrieb John D. Ament <jo...@apache.org>:
> >
> > Mark,
> >
> > SE support is still a long ways from being done. Most of the issues are
> > resolved, all of the remaining problems are related to OWB not honoring
> > when the container's been shutdown.
> >
> > The good news, by removing the automatic starting of request context and
> > properly shutting down app context in the SELifeCycle class, OWB is
> finally
> > marking the proxies as invalid, but it seems like we still need to add an
> > isRunning check somewhere.
> >
> > John
> >
> > On Tue, Aug 15, 2017 at 7:19 AM Mark Struberg <struberg@yahoo.de.invalid
> >
> > wrote:
> >
> >> Hi folks!
> >>
> >> I'd love to fix OWB-1209 and get Johns SE changes in.
> >> I think we are then ready to roll a 2.0.1 release, isn't?
> >>
> >> John, I'll be available on IRC to coordinate and review your proposed SE
> >> changes.
> >> Of course we could also discuss it via IRC, but might be easier to give
> >> that feedback via a shared hangout screen.
> >>
> >> LieGrue,
> >> strub
> >> .
> >>
>
>
Re: [DISCUSS] Release OWB-2.0.1 ?
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
Oki, that seems to be a bit more work to be left still.
I'd then suggest to go on with the immanent features and release OWB-2.0.1 pretty soon while targetting 2.0.2 for the SE work.
txs and LieGrue,
strub
> Am 15.08.2017 um 13:48 schrieb John D. Ament <jo...@apache.org>:
>
> Mark,
>
> SE support is still a long ways from being done. Most of the issues are
> resolved, all of the remaining problems are related to OWB not honoring
> when the container's been shutdown.
>
> The good news, by removing the automatic starting of request context and
> properly shutting down app context in the SELifeCycle class, OWB is finally
> marking the proxies as invalid, but it seems like we still need to add an
> isRunning check somewhere.
>
> John
>
> On Tue, Aug 15, 2017 at 7:19 AM Mark Struberg <st...@yahoo.de.invalid>
> wrote:
>
>> Hi folks!
>>
>> I'd love to fix OWB-1209 and get Johns SE changes in.
>> I think we are then ready to roll a 2.0.1 release, isn't?
>>
>> John, I'll be available on IRC to coordinate and review your proposed SE
>> changes.
>> Of course we could also discuss it via IRC, but might be easier to give
>> that feedback via a shared hangout screen.
>>
>> LieGrue,
>> strub
>> .
>>
Re: [DISCUSS] Release OWB-2.0.1 ?
Posted by "John D. Ament" <jo...@apache.org>.
Mark,
SE support is still a long ways from being done. Most of the issues are
resolved, all of the remaining problems are related to OWB not honoring
when the container's been shutdown.
The good news, by removing the automatic starting of request context and
properly shutting down app context in the SELifeCycle class, OWB is finally
marking the proxies as invalid, but it seems like we still need to add an
isRunning check somewhere.
John
On Tue, Aug 15, 2017 at 7:19 AM Mark Struberg <st...@yahoo.de.invalid>
wrote:
> Hi folks!
>
> I'd love to fix OWB-1209 and get Johns SE changes in.
> I think we are then ready to roll a 2.0.1 release, isn't?
>
> John, I'll be available on IRC to coordinate and review your proposed SE
> changes.
> Of course we could also discuss it via IRC, but might be easier to give
> that feedback via a shared hangout screen.
>
> LieGrue,
> strub
> .
>