[jira] [Commented] (BROOKLYN-166) Use a feature rich yaml editor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BROOKLYN-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708581#comment-14708581 ] 

ASF GitHub Bot commented on BROOKLYN-166:
-----------------------------------------

GitHub user azbarcea opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/865

    [BROOKLYN-166] add codemirror, yaml syntax-highlighting, autocompletion)

    I was looking into the `codemirror` integration.
    
    I didn't integrate it in all the views, only in `application-add-wizard.js`, and I look forward to your feedback.
    
    I tried to improve the `scroll down` and now, there aren't 2 scrollers. There is only one for the editor.
    
    The following things are still open:
    * I excluded `rat-plugin` for the files added (actually, right now excludes the whole `src`).
    * I had to modify the original codemirror addons and modes to include `codemirror` instead of `../../lib/codemirror`
    * The way `angular.js` views and `require.js` is used (using the `config.js`), make the presumptions the `javascript` libraries are static in `libs`. Similar to `mvn`, I propose `grunt` and `npm` to be used, so that the whole `libs` directory to disappear.
    * I have no `yaml-hint.js`, or even `camp-hint.js`. I need to study further the CAMP spec for it. I think also that `brooklyn` has a little different spec for `.yaml` files, extending the language. I am right? Right now, I used the `anyword-hint.js`, which adds to the hints (auto-completion), the words that already exist in the document.
    * There are many themes that can be added, I will also add a configuration for: addons, modes, themes to be used globally. Maybe this should be at user profile level ?!?
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/azbarcea/incubator-brooklyn codemirror-yaml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/865.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #865
    
----
commit b0aff5d92826df8fbd2f673c8b8d728613ce4115
Author: Alexandru Zbarcea <al...@apache.org>
Date:   2015-08-23T22:27:45Z

    [BROOKLYN-166] add codemirror, yaml syntax-highlighting, autocompletion)

----


> Use a feature rich yaml editor
> ------------------------------
>
>                 Key: BROOKLYN-166
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-166
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Hadrian Zbarcea
>             Fix For: 0.8.0
>
>
> Brooklyn would benefit from a feature rich editor that would give a user more feedback on what is possible when editing a camp blueprint.
> The best candidate is imho codemirror, used by many apps, including swagger.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)