You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Venkatesh Sivasubramanian <so...@gmail.com> on 2013/10/10 05:23:08 UTC

Review Request 14569: Patch for FLUME-2120

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/
-----------------------------------------------------------

Review request for Flume.


Bugs: Flume-2120
    https://issues.apache.org/jira/browse/Flume-2120


Repository: flume-git


Description
-------

Pls. find the patch attached for the FLUME-2120. 

I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java db9e0fd 
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 2d7a429 

Diff: https://reviews.apache.org/r/14569/diff/


Testing
-------

JUnit added for SyslogUDPSource.


Thanks,

Venkatesh Sivasubramanian

Re: Review Request 14569: Patch for FLUME-2120

Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/#review27428
-----------------------------------------------------------


Hey Venkatesh, sorry about this, Jeff originally had a test in his patch but I screwed up and missed it in my git commit. I corrected that, so please rebase your changes on top of TestSyslogTcpSource.java from FLUME-1666. Thanks!

- Mike Percy


On Oct. 20, 2013, 6:23 p.m., Venkatesh Sivasubramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14569/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2013, 6:23 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: Flume-2120
>     https://issues.apache.org/jira/browse/Flume-2120
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Pls. find the patch attached for the FLUME-2120. 
> 
> I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
> I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 7a12d27 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTCPSource.java PRE-CREATION 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java eae26ed 
> 
> Diff: https://reviews.apache.org/r/14569/diff/
> 
> 
> Testing
> -------
> 
> JUnit added for SyslogUDPSource and SyslogTcpSource
> 
> 
> Thanks,
> 
> Venkatesh Sivasubramanian
> 
>

Re: Review Request 14569: Patch for FLUME-2120

Posted by Venkatesh Sivasubramanian <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/
-----------------------------------------------------------

(Updated Nov. 2, 2013, 7:03 p.m.)


Review request for Flume.


Changes
-------

Hi Hari: I have rebased the code. Pls. let me know if you have any feedback. 

Thanks
Venkatesh


Bugs: Flume-2120
    https://issues.apache.org/jira/browse/Flume-2120


Repository: flume-git


Description
-------

Pls. find the patch attached for the FLUME-2120. 

I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.


Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 7a12d27 
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java a6a1d5b 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java eae26ed 

Diff: https://reviews.apache.org/r/14569/diff/


Testing
-------

JUnit added for SyslogUDPSource and SyslogTcpSource


Thanks,

Venkatesh Sivasubramanian

Re: Review Request 14569: Patch for FLUME-2120

Posted by Venkatesh Sivasubramanian <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/
-----------------------------------------------------------

(Updated Oct. 24, 2013, 7:47 a.m.)


Review request for Flume.


Changes
-------

Hi Mike: No worries! I have rebased the code and regenerated the diff file. Pls. review and let me know if you have any feedback/suggestions.

Thanks
Venkatesh


Bugs: Flume-2120
    https://issues.apache.org/jira/browse/Flume-2120


Repository: flume-git


Description
-------

Pls. find the patch attached for the FLUME-2120. 

I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.


Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 7a12d27 
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java a6a1d5b 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java eae26ed 

Diff: https://reviews.apache.org/r/14569/diff/


Testing
-------

JUnit added for SyslogUDPSource and SyslogTcpSource


Thanks,

Venkatesh Sivasubramanian

Re: Review Request 14569: Patch for FLUME-2120

Posted by Venkatesh Sivasubramanian <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/
-----------------------------------------------------------

(Updated Oct. 20, 2013, 6:23 p.m.)


Review request for Flume.


Changes
-------

Hi Jeff: Sorry, the FLUME-1666 commit didn't have changes done to TestMultiportSyslogTCPSource. It had test cases added in TestSyslogUdpSource. But couldnt find anything for SyslogTcpSource, so went ahead and added a new test class for SyslogTcpSource. 

Thanks!


Bugs: Flume-2120
    https://issues.apache.org/jira/browse/Flume-2120


Repository: flume-git


Description
-------

Pls. find the patch attached for the FLUME-2120. 

I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 7a12d27 
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTCPSource.java PRE-CREATION 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java eae26ed 

Diff: https://reviews.apache.org/r/14569/diff/


Testing (updated)
-------

JUnit added for SyslogUDPSource and SyslogTcpSource


Thanks,

Venkatesh Sivasubramanian

Re: Review Request 14569: Patch for FLUME-2120

Posted by Venkatesh Sivasubramanian <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/
-----------------------------------------------------------

(Updated Oct. 20, 2013, 6:11 p.m.)


Review request for Flume.


Changes
-------

Jeff, 
I have rebased the patch against the trunk and have uploaded the latest diff. I noticed the test class that was modified for FLUME-1666 was in TestMultiportSyslogTCPSource and it has test cases for MultiportSyslogTCPSource. So I went ahead and added a separate class TestSyslogTCPSource for SyslogTCPSource.

Thanks
Venkatesh


Bugs: Flume-2120
    https://issues.apache.org/jira/browse/Flume-2120


Repository: flume-git


Description
-------

Pls. find the patch attached for the FLUME-2120. 

I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.


Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 7a12d27 
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTCPSource.java PRE-CREATION 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java eae26ed 

Diff: https://reviews.apache.org/r/14569/diff/


Testing
-------

JUnit added for SyslogUDPSource.


Thanks,

Venkatesh Sivasubramanian

Re: Review Request 14569: Patch for FLUME-2120

Posted by Jeff jlord <jl...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/#review26972
-----------------------------------------------------------


Venkatesh, 

I just added a test for the tcp syslog source in FLUME-1666
Can you rebase against trunk and add a source counter test there?

Thank You,

Jeff

- Jeff jlord


On Oct. 10, 2013, 3:23 a.m., Venkatesh Sivasubramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14569/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 3:23 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: Flume-2120
>     https://issues.apache.org/jira/browse/Flume-2120
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Pls. find the patch attached for the FLUME-2120. 
> 
> I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
> I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java db9e0fd 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 2d7a429 
> 
> Diff: https://reviews.apache.org/r/14569/diff/
> 
> 
> Testing
> -------
> 
> JUnit added for SyslogUDPSource.
> 
> 
> Thanks,
> 
> Venkatesh Sivasubramanian
> 
>