[GitHub] [accumulo] milleruntime commented on pull request #2270: Rename CompactionTask to InternalJob

[GitBox <gi...@apache.org>]

milleruntime commented on pull request #2270:
URL: https://github.com/apache/accumulo/pull/2270#issuecomment-919289779


   > Without understanding the code - it seems that internalJob and externalJob miss a chance to provide context with what they are doing, esp. if strictly related to compactions. 
   
   We could add "compaction" to the names but that seems unnecessary as they are only used within the `CompactionExecutor` and tserver.compaction package. If you follow the code from tserver, it is more clear then taken out of context in a PR. A `CompactionJob` is the immutable object that will get run. A `SubmittedJob` is a wrapper around a `CompactionJob`, that provides the status. Then `ExternalJob` and `InternalJob` are two types of `SubmittedJob` that can be run.
   
   > Also, although task and job are interchangeable, task seems to imply something that is narrow in scope and maybe just a step - job seems to imply larger and self contained. Like you submit a MR job that can contain multiple tasks. So not sure what is more appropriate in this context.
   
   It seems we could settle on Job here as a name for a unit of work. Perhaps @keith-turner may have had some other ideas?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org