You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pivot.apache.org by tv...@apache.org on 2009/08/02 00:29:04 UTC

svn commit: r799941 - /incubator/pivot/trunk/core/src/org/apache/pivot/collections/FilteredList.java

Author: tvolkert
Date: Sat Aug  1 22:29:04 2009
New Revision: 799941

URL: http://svn.apache.org/viewvc?rev=799941&view=rev
Log:
Fixed bug in FilteredList - calling add() from within setFilter() and setSource() was causing us to try to add items to the source list that were already in the source list

Modified:
    incubator/pivot/trunk/core/src/org/apache/pivot/collections/FilteredList.java

Modified: incubator/pivot/trunk/core/src/org/apache/pivot/collections/FilteredList.java
URL: http://svn.apache.org/viewvc/incubator/pivot/trunk/core/src/org/apache/pivot/collections/FilteredList.java?rev=799941&r1=799940&r2=799941&view=diff
==============================================================================
--- incubator/pivot/trunk/core/src/org/apache/pivot/collections/FilteredList.java (original)
+++ incubator/pivot/trunk/core/src/org/apache/pivot/collections/FilteredList.java Sat Aug  1 22:29:04 2009
@@ -201,7 +201,7 @@
                 for (T item : source) {
                     if (filter == null
                         || filter.include(item)) {
-                        add(item);
+                        listListeners.itemInserted(this, view.add(item));
                     }
                 }
             }
@@ -243,7 +243,7 @@
                 for (T item : source) {
                     if (filter == null
                         || filter.include(item)) {
-                        add(item);
+                        listListeners.itemInserted(this, view.add(item));
                     }
                 }
             }