You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/21 08:34:27 UTC
[GitHub] [iotdb] jun0315 opened a new pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
jun0315 opened a new pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440
see : https://issues.apache.org/jira/browse/IOTDB-2038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440#issuecomment-974781544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440#discussion_r753807905
##########
File path: server/src/main/java/org/apache/iotdb/db/mqtt/PublishHandler.java
##########
@@ -64,6 +71,26 @@ public String getID() {
return "iotdb-mqtt-broker-listener";
Review comment:
We can add a session id suffix to the id name :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440#discussion_r753807905
##########
File path: server/src/main/java/org/apache/iotdb/db/mqtt/PublishHandler.java
##########
@@ -64,6 +71,26 @@ public String getID() {
return "iotdb-mqtt-broker-listener";
Review comment:
We can add a session id suffix to the id name :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440#issuecomment-974781544
[](https://coveralls.io/builds/44430671)
Coverage increased (+0.1%) to 67.082% when pulling **631a6741acddf3fd27b9981a80f3c2cb21abd46a on jun0315:mqtt_access_basic_provider** into **d9d8733f17878cd07e4510a7f9b3af92049863c3 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440#issuecomment-974781544
[](https://coveralls.io/builds/44428655)
Coverage increased (+0.04%) to 67.011% when pulling **fa091afb8df3328605a189360d8be4b4862cd290 on jun0315:mqtt_access_basic_provider** into **d9d8733f17878cd07e4510a7f9b3af92049863c3 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440#issuecomment-974781544
[](https://coveralls.io/builds/44428655)
Coverage increased (+0.04%) to 67.011% when pulling **fa091afb8df3328605a189360d8be4b4862cd290 on jun0315:mqtt_access_basic_provider** into **d9d8733f17878cd07e4510a7f9b3af92049863c3 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4440: [IOTDB-2038] MqttService accesses to BasicServiceProvider
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4440:
URL: https://github.com/apache/iotdb/pull/4440#issuecomment-974781544
[](https://coveralls.io/builds/44430515)
Coverage increased (+0.1%) to 67.08% when pulling **631a6741acddf3fd27b9981a80f3c2cb21abd46a on jun0315:mqtt_access_basic_provider** into **d9d8733f17878cd07e4510a7f9b3af92049863c3 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org