You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/22 01:19:58 UTC
[GitHub] [hbase] jojochuang opened a new pull request #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
jojochuang opened a new pull request #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196
Add a NOTE in Appendix L warning that users are advised not to follow the instructions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-590014698
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 38s | master passed |
| +0 :ok: | refguide | 4m 52s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 1s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 4m 45s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 22m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1196 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 6fcfce720ef5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1196/out/precommit/personality/provided.sh |
| git revision | master / 400b7ce954 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/patch-site/book.html |
| Max. process+thread count | 96 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-590250093
Looks good to you @busbey ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #1196: HBASE-23755. [OpenTracing]
Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-589910940
let's delete the section instead? and update the htrace note in the upgrade paths section to note that it's broken?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-589904376
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 33s | master passed |
| +0 :ok: | refguide | 4m 45s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 2s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 4m 48s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 22m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1196 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux a5340aa3a75c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1196/out/precommit/personality/provided.sh |
| git revision | master / 400b7ce954 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/patch-site/book.html |
| Max. process+thread count | 96 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani merged pull request #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
virajjasani merged pull request #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-590409275
> The change looks good to me. Should be included on all branches-2.
>
> I haven't been able to see the update in the rendered ref guide from the qabot. Presuming that looks fine to whoever merges I'm good.
Roger that. Just realized it, let me trigger one more build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-590422551
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 27s | master passed |
| +0 :ok: | refguide | 4m 47s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 5s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 4m 46s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 21m 53s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1196 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 306f9e5a0a56 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1196/out/precommit/personality/provided.sh |
| git revision | master / 418234356f |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/3/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/3/artifact/out/patch-site/book.html |
| Max. process+thread count | 75 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #1196: HBASE-23755. [OpenTracing]
Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-590441492
yep that looks great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-590411521
@busbey the changes are available in patch-site refguide: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/patch-site/book.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani edited a comment on issue #1196: HBASE-23755.
[OpenTracing] Declare HTrace is unusable in the user doc
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
URL: https://github.com/apache/hbase/pull/1196#issuecomment-590411521
@busbey the changes are available in patch-site refguide: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/patch-site/book.html
But not in branch-site guide: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/2/artifact/out/branch-site/book.html
Which is expected right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services