[GitHub] apeforest commented on a change in pull request #13000: fix quantize_graph pass error when there're multiple outputs from a single node

[GitBox <gi...@apache.org>]

apeforest commented on a change in pull request #13000: fix quantize_graph pass error when there're multiple outputs from a single node
URL: https://github.com/apache/incubator-mxnet/pull/13000#discussion_r234396759
 
 

 ##########
 File path: src/operator/quantization/quantize_graph_pass.cc
 ##########
 @@ -117,9 +117,10 @@ inline bool NeedQuantize(NodePtr node, const std::unordered_set<std::string>& ex
 }
 
 Graph QuantizeGraph(Graph &&src) {
-  static auto& quantized_op_map = Op::GetAttr<mxnet::FQuantizedOp>("FQuantizedOp");
-  static auto& need_requantize_map = Op::GetAttr<mxnet::FNeedRequantize>("FNeedRequantize");
-  static auto& avoid_quantize_input_map =
+  static const auto& flist_outputs = nnvm::Op::GetAttr<nnvm::FListOutputNames>("FListOutputNames");
 
 Review comment:
   nit: output_list is a better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services