[GitHub] [doris] yiguolei commented on a diff in pull request #20694: [enhancement](insert-stmt) Make `insert into tbl values();` compatible with mysql

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #20694:
URL: https://github.com/apache/doris/pull/20694#discussion_r1227399182


##########
regression-test/suites/load_p0/insert/test_insert.groovy:
##########
@@ -48,4 +48,24 @@ suite("test_insert") {
     """
 
     qt_sql1 "select * from ${insert_tbl} order by 1, 2, 3, 4"
+
+    def insert_tbl_dft = "test_insert_dft_tbl"
+    sql """ DROP TABLE IF EXISTS ${insert_tbl_dft}"""
+    sql """
+        CREATE TABLE ${insert_tbl_dft} (
+            `k1` char(8) DEFAULT "hello",
+            `k2` char(8) DEFAULT "world",
+            `k3` int(10) DEFAULT "0"

Review Comment:
   add more column types to the test:
   1. the column is date type, set its default value
   2. the column is date type and its default value is a expr, current_timestamp



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org