[GitHub] [incubator-mxnet] szha commented on a change in pull request #20523: [v1.9.x] stop closing opened libs

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #20523:
URL: https://github.com/apache/incubator-mxnet/pull/20523#discussion_r689950052



##########
File path: include/mxnet/c_api.h
##########
@@ -233,10 +233,11 @@ MXNET_DLL const char *MXGetLastError();
 /*!
  * \brief Load library dynamically
  * \param path to the library .so file
- * \param 0 for quiet, 1 for verbose
+ * \param verbose 0 for quiet, 1 for verbose
+ * \param lib handle to opened library
  * \return 0 when success, -1 when failure happens.
  */
-MXNET_DLL int MXLoadLib(const char *path, unsigned verbose);
+MXNET_DLL int MXLoadLib(const char *path, unsigned verbose, void** lib);

Review comment:
       This is a C API change. Is it required for the fix?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org