You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/18 20:58:38 UTC

[GitHub] [tvm] CircleSpin opened a new pull request #7698: [TVMC] Python Scripting Init Files

CircleSpin opened a new pull request #7698:
URL: https://github.com/apache/tvm/pull/7698


   This PR adds to two init files to make tvmc cleaner for running python scripts. For example, instead of running tvmc.runner.run_module() you can now run tvmc.run()


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] CircleSpin commented on pull request #7698: [TVMC] Python Scripting Init Files

Posted by GitBox <gi...@apache.org>.
CircleSpin commented on pull request #7698:
URL: https://github.com/apache/tvm/pull/7698#issuecomment-802294361


   @jwfromm @leandron @mdw-octoml 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] CircleSpin commented on pull request #7698: [TVMC] Python Scripting Init Files

Posted by GitBox <gi...@apache.org>.
CircleSpin commented on pull request #7698:
URL: https://github.com/apache/tvm/pull/7698#issuecomment-803190225


   I've modified the test files so that they use new the importing syntax. Does this look good to you @leandron ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] comaniac commented on pull request #7698: [TVMC] Python Scripting Init Files

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7698:
URL: https://github.com/apache/tvm/pull/7698#issuecomment-804674880


   Just a guess. Is that due to circular dependency?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm commented on pull request #7698: [TVMC] Python Scripting Init Files

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7698:
URL: https://github.com/apache/tvm/pull/7698#issuecomment-804449105


   @merrymercy this PR is failing with this error message `AttributeError: module 'tvm.auto_scheduler._ffi_api' has no attribute 'RandomModel'`, which almost certainly isn't caused by the changes made. Do you know what's going on?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm merged pull request #7698: [TVMC] Python Scripting Init Files

Posted by GitBox <gi...@apache.org>.
jwfromm merged pull request #7698:
URL: https://github.com/apache/tvm/pull/7698


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm commented on pull request #7698: [TVMC] Python Scripting Init Files

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7698:
URL: https://github.com/apache/tvm/pull/7698#issuecomment-802552863


   @leandron yeah we think TVMC has an excellent set of utilities to make it a simplified python API for new users, kind of like keras. You did an awesome job packing tons of functionality into a few key function calls, but some of them need some small changes to better accommodate access from Python. @CircleSpin is working on making these changes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mdw-octoml commented on a change in pull request #7698: [TVMC] Python Scripting Init Files

Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on a change in pull request #7698:
URL: https://github.com/apache/tvm/pull/7698#discussion_r597240308



##########
File path: python/tvm/driver/tvmc/__init__.py
##########
@@ -21,3 +21,6 @@
 from . import autotuner
 from . import compiler
 from . import runner
+from .frontends import load_model as load
+from .compiler import compile_model as compile
+from .runner import run_module as run

Review comment:
       Note need for newline at end of file
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jwfromm commented on pull request #7698: [TVMC] Python Scripting Init Files

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7698:
URL: https://github.com/apache/tvm/pull/7698#issuecomment-805949425


   Thanks @CircleSpin @leandron and @comaniac. This is now merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org