[GitHub] [zeppelin] zjffdu commented on a change in pull request #3927: [ZEPPELIN-4409]. Set spark.app.name to know which user is running which notebook

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #3927:
URL: https://github.com/apache/zeppelin/pull/3927#discussion_r502244505



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java
##########
@@ -78,6 +78,15 @@ public SparkInterpreterLauncher(ZeppelinConfiguration zConf, RecoveryStorage rec
       }
     }
 
+    // set spark.app.name if it is not set or empty
+    if (!sparkProperties.containsKey("spark.app.name") ||
+            StringUtils.isBlank(sparkProperties.getProperty("spark.app.name"))) {
+      sparkProperties.setProperty("spark.app.name", context.getInterpreterGroupId());
+    } else {
+      String appName = context.getInterpreterGroupId();
+      sparkProperties.setProperty("spark.app.name", appName);

Review comment:
       oops, I should remove this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org