[GitHub] [nifi] Lehel44 commented on a change in pull request #5419: NIFI-9255: Support asynchronous session commits in ListenHTTP

[GitBox <gi...@apache.org>]

Lehel44 commented on a change in pull request #5419:
URL: https://github.com/apache/nifi/pull/5419#discussion_r718689995



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/servlets/ListenHTTPServlet.java
##########
@@ -424,6 +424,8 @@ protected void proceedFlow(final HttpServletRequest request, final HttpServletRe
                         response.setStatus(this.returnCode);
                         asyncContext.complete();
                     }, t -> {
+                        logger.error("Failed to commit session. Returning error response to Remote Host: [{}] Port [{}] SubjectDN [{}] IssuerDN [{}]",
+                                new Object[] {request.getRemoteHost(), request.getRemotePort(), foundSubject, foundIssuer}, t);

Review comment:
       This object wrapping is very common due to legacy usage. Do you think we could deprecate `ComponentLog::void error(String msg, Object[] os, Throwable t)` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org