You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dubbo.apache.org by wongoo <wo...@apache.org> on 2020/03/30 00:54:52 UTC

[VOTE] Release Apache dubbo-go-hessian2 v1.5.0 RC1

Hello Dubbo/Dubbogo Community,

 This is a call for vote to release Apache dubbo-go-hessian2 version v1.5.0
RC1.

 The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.5.0-rc1/
 Git tag for the release:
https://github.com/apache/dubbo-go-hessian2/tree/1.5
 Hash for the release tag: e026b32f47d548e1d8051ac769364aa67678df3f
 Release Notes:
https://github.com/apache/dubbo-go-hessian2/blob/1.5/CHANGE.md
 The artifacts have been signed with Key :7DB68550D366E4C0, which can be
found in the keys file:
 https://dist.apache.org/repos/dist/dev/dubbo/KEYS

 The vote will be open for at least 72 hours or until necessary number of
votes are reached.

 Please vote accordingly:
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove with the reason

 Thanks,
 The Apache Dubbo-go Team

Re: [VOTE] Release Apache dubbo-go-hessian2 v1.5.0 RC1

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

+1 (binding)

I checked:
- signatures and hashes are fine
- LICENSE is missing the appendix. Please fix this.
- NOTICE is fine
- No unexpected binary files
- All source file have ASF headers
- can compile from source

Thanks,
Justin

Re: [VOTE] Release Apache dubbo-go-hessian2 v1.5.0 RC1

Posted by stocks alex <al...@apache.org>.

Hi,

+1 (binding)

I checked:
- LICENSE exists in all code files
- All source file have ASF license header
- all unit tests passed

however, pls update the dependency libs with them latest version in go.mod:
- github.com/dubbogo/gost v1.8.0
- github.com/pkg/errors v0.9.1
- github.com/stretchr/testify v1.5.1

And also pls add comment for public struct/functions in
- java_collection.go
- request.go
- serialize.go

Jun Liu <li...@apache.org> 于2020年3月30日周一 下午2:21写道：

> Hi,
>
> +1 (binding)
>
> I checked:
> - Signatures and hashes are good
> - LICENSE and NOTICE exist
> - All source files have ASF headers by run the tool provided by dubbogo
> 'license-header-checker -v -a -r -i /apache-license.txt
> ./dubbo-go-hessian2/v1.5.0-rc1/ go'
>
> Jun
>
> > On Mar 30, 2020, at 8:54 AM, wongoo <wo...@apache.org> wrote:
> >
> > Hello Dubbo/Dubbogo Community,
> >
> > This is a call for vote to release Apache dubbo-go-hessian2 version
> v1.5.0
> > RC1.
> >
> > The release candidates:
> >
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.5.0-rc1/
> > Git tag for the release:
> > https://github.com/apache/dubbo-go-hessian2/tree/1.5
> > Hash for the release tag: e026b32f47d548e1d8051ac769364aa67678df3f
> > Release Notes:
> > https://github.com/apache/dubbo-go-hessian2/blob/1.5/CHANGE.md
> > The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo-go Team
>
>

Re: [VOTE] Release Apache dubbo-go-hessian2 v1.5.0 RC1

Posted by Jun Liu <li...@apache.org>.

Hi,

+1 (binding)

I checked:
- Signatures and hashes are good
- LICENSE and NOTICE exist
- All source files have ASF headers by run the tool provided by dubbogo 'license-header-checker -v -a -r -i /apache-license.txt ./dubbo-go-hessian2/v1.5.0-rc1/ go'

Jun

> On Mar 30, 2020, at 8:54 AM, wongoo <wo...@apache.org> wrote:
> 
> Hello Dubbo/Dubbogo Community,
> 
> This is a call for vote to release Apache dubbo-go-hessian2 version v1.5.0
> RC1.
> 
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.5.0-rc1/
> Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.5
> Hash for the release tag: e026b32f47d548e1d8051ac769364aa67678df3f
> Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.5/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> 
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo-go Team