You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/08/05 10:41:32 UTC
[GitHub] [skywalking-rust] jmjoy opened a new pull request, #40: Adjust the trace structure.
jmjoy opened a new pull request, #40:
URL: https://github.com/apache/skywalking-rust/pull/40
To add logging and metrics in the future, adjust the structure of the trace.
1. Rename mod `context` to `trace`.
2. Move `reporter` to `trace`, and rename `Reporter` to `TraceReporter`, and do so for implementers.
3. Add the `logging` mod and base structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #40: Adjust the trace structure.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #40:
URL: https://github.com/apache/skywalking-rust/pull/40#issuecomment-1206550199
> > Move reporter to trace, and rename Reporter to TraceReporter, and do so for implementers.
>
> Mostly, we recommend only having one global reporter for trace, log, and metrics.
Alright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on a diff in pull request #40: Adjust the trace structure.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #40:
URL: https://github.com/apache/skywalking-rust/pull/40#discussion_r938744436
##########
build.rs:
##########
@@ -19,7 +19,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
.build_server(false)
.type_attribute(".", "#[derive(serde::Serialize, serde::Deserialize)]")
.compile(
- &["./skywalking-data-collect-protocol/language-agent/Tracing.proto"],
+ &[
+ "./skywalking-data-collect-protocol/language-agent/Tracing.proto",
+ "./skywalking-data-collect-protocol/logging/Logging.proto",
Review Comment:
I think log report doesn't implement in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng merged pull request #40: Adjust the trace structure.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #40:
URL: https://github.com/apache/skywalking-rust/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on a diff in pull request #40: Adjust the trace structure.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on code in PR #40:
URL: https://github.com/apache/skywalking-rust/pull/40#discussion_r938901077
##########
build.rs:
##########
@@ -19,7 +19,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
.build_server(false)
.type_attribute(".", "#[derive(serde::Serialize, serde::Deserialize)]")
.compile(
- &["./skywalking-data-collect-protocol/language-agent/Tracing.proto"],
+ &[
+ "./skywalking-data-collect-protocol/language-agent/Tracing.proto",
+ "./skywalking-data-collect-protocol/logging/Logging.proto",
Review Comment:
Yes, is better to restore it and add it in future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on a diff in pull request #40: Adjust the trace structure.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #40:
URL: https://github.com/apache/skywalking-rust/pull/40#discussion_r938743911
##########
build.rs:
##########
@@ -19,7 +19,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
.build_server(false)
.type_attribute(".", "#[derive(serde::Serialize, serde::Deserialize)]")
.compile(
- &["./skywalking-data-collect-protocol/language-agent/Tracing.proto"],
+ &[
+ "./skywalking-data-collect-protocol/language-agent/Tracing.proto",
+ "./skywalking-data-collect-protocol/logging/Logging.proto",
Review Comment:
This is for further using, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] codecov-commenter commented on pull request #40: Adjust the trace structure.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #40:
URL: https://github.com/apache/skywalking-rust/pull/40#issuecomment-1206310749
# [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/40?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#40](https://codecov.io/gh/apache/skywalking-rust/pull/40?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4540af9) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/fa8ba85d5d51e70f7a79679fe6db8e292cfec11a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa8ba85) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 45.23% 45.23%
=======================================
Files 14 14
Lines 378 378
=======================================
Hits 171 171
Misses 207 207
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-rust/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/skywalking\_proto/v3/mod.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3NreXdhbGtpbmdfcHJvdG8vdjMvbW9kLnJz) | `0.00% <ø> (ø)` | |
| [src/trace/propagation/context.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3Byb3BhZ2F0aW9uL2NvbnRleHQucnM=) | `100.00% <ø> (ø)` | |
| [src/trace/propagation/decoder.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3Byb3BhZ2F0aW9uL2RlY29kZXIucnM=) | `91.17% <ø> (ø)` | |
| [src/trace/propagation/encoder.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3Byb3BhZ2F0aW9uL2VuY29kZXIucnM=) | `100.00% <ø> (ø)` | |
| [src/trace/reporter/grpc.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3JlcG9ydGVyL2dycGMucnM=) | `0.00% <ø> (ø)` | |
| [src/trace/reporter/log.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3JlcG9ydGVyL2xvZy5ycw==) | `21.05% <ø> (ø)` | |
| [src/trace/reporter/mod.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3JlcG9ydGVyL21vZC5ycw==) | `100.00% <ø> (ø)` | |
| [src/trace/span.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3NwYW4ucnM=) | `0.00% <ø> (ø)` | |
| [src/trace/system\_time.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3N5c3RlbV90aW1lLnJz) | `0.00% <ø> (ø)` | |
| [src/trace/trace\_context.rs](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RyYWNlL3RyYWNlX2NvbnRleHQucnM=) | `24.48% <ø> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking-rust/pull/40/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #40: Adjust the trace structure.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #40:
URL: https://github.com/apache/skywalking-rust/pull/40#issuecomment-1206369235
> Move reporter to trace, and rename Reporter to TraceReporter, and do so for implementers.
Mostly, we recommend only having one global reporter for trace, log, and metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on a diff in pull request #40: Adjust the trace structure.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #40:
URL: https://github.com/apache/skywalking-rust/pull/40#discussion_r938903059
##########
build.rs:
##########
@@ -19,7 +19,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
.build_server(false)
.type_attribute(".", "#[derive(serde::Serialize, serde::Deserialize)]")
.compile(
- &["./skywalking-data-collect-protocol/language-agent/Tracing.proto"],
+ &[
+ "./skywalking-data-collect-protocol/language-agent/Tracing.proto",
+ "./skywalking-data-collect-protocol/logging/Logging.proto",
Review Comment:
It is fine, I just want to confirm this. It is OK to keep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org