[GitHub] [cordova] gartorware edited a comment on issue #95: Android location permissions not being requested using Cordova 9

[GitBox <gi...@apache.org>]

gartorware edited a comment on issue #95: Android location permissions not being requested using Cordova 9
URL: https://github.com/apache/cordova/issues/95#issuecomment-503555106
 
 
   > Okay, so using your new script, if I start completely fresh (nuke node_modules, platforms, and plugins), do an `npm install`, and then run `cordova prepare`, then `cordova build android`, I end up with no difference from what I had before adding the hook. Still missing some of the permissions.
   > 
   > Again, I don't necessarily need the workaround for now, I am just hoping for a fix. Any news on that front @knight9999 or @raphinesse?
   
   The problem here is that cordova@9 generates a wrong manifest even while removing/adding platform from scratch.
   
   I have managed to use the workaround suggested (btw, thank you very much @cyparu) by downgrading cordova to version 8, removing android platform, adding it again (AndroidManifest.xml is correct on this point), uninstalling cordova 8, installing cordova 9.
   
   BTW, facing this issue on several projects. Not only for third party plugins, but for own edit-config tags. I cannot use my own network_security_config, which used to work on cordova 8 (this edit-config is default on ionic):
   ```
   <edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application" xmlns:android="http://schemas.android.com/apk/res/android">
       <application android:networkSecurityConfig="@xml/network_security_config" />
   </edit-config>
   <resource-file src="resources/android/xml/network_security_config.xml" target="app/src/main/res/xml/network_security_config.xml" />
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org