You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/16 03:51:17 UTC
[GitHub] [incubator-superset] zhaoyongjie opened a new pull request #10902: fix: babel script broken by format string
zhaoyongjie opened a new pull request #10902:
URL: https://github.com/apache/incubator-superset/pull/10902
### SUMMARY
babel script broken by format string, runing after translation script
```
flask fab babel-extract --target superset/translations --output superset/translations/messages.pot --config superset/translations/babel.cfg -k _ -k __ -k t -k tn -k tct
```
raise bable exception
<img width="1218" alt="image" src="https://user-images.githubusercontent.com/2016594/93290141-a506af80-f812-11ea-97bd-0c8c24308a9e.png">
### TEST PLAN
Do we need a tox task to add the translation testing? @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10902: fix: babel script broken by format string
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10902:
URL: https://github.com/apache/incubator-superset/pull/10902#issuecomment-693650744
Open question to @mistercrunch but this change LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #10902: fix: babel script broken by format string
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10902:
URL: https://github.com/apache/incubator-superset/pull/10902#issuecomment-693651585
We have CI checks for translation, I'm surprised this wasn't caught by those.
https://github.com/apache/incubator-superset/runs/1121177228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10902: fix: babel script broken by format string
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10902:
URL: https://github.com/apache/incubator-superset/pull/10902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org