You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/09 09:11:21 UTC
[GitHub] [lucene] romseygeek commented on a change in pull request #679: Monitor Improvements LUCENE-10422
romseygeek commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r822427351
##########
File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##########
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.monitor;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.search.*;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.util.BytesRef;
+import org.apache.lucene.util.IOUtils;
+import org.apache.lucene.util.NamedThreadFactory;
+
+class ReadonlyQueryIndex extends QueryIndex {
+
+ private final ScheduledExecutorService refreshExecutor;
+
+ public ReadonlyQueryIndex(MonitorConfiguration configuration) throws IOException {
+ if (configuration.getDirectoryProvider() == null) {
+ throw new IllegalStateException(
+ "You must specify a Directory when configuring a Monitor as read-only.");
+ }
+ Directory directory = configuration.getDirectoryProvider().get();
+ this.manager = new SearcherManager(directory, new TermsHashBuilder(termFilters));
+ this.decomposer = configuration.getQueryDecomposer();
+ this.serializer = configuration.getQuerySerializer();
+ this.refreshExecutor =
+ Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("cache-purge"));
+ long refreshFrequency = configuration.getPurgeFrequency();
+ this.refreshExecutor.scheduleAtFixedRate(
+ () -> {
+ try {
+ manager.maybeRefresh();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ },
+ refreshFrequency,
+ refreshFrequency,
+ configuration.getPurgeFrequencyUnits());
+ }
+
+ @Override
+ public void commit(List<MonitorQuery> updates) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot commit");
+ }
+
+ @Override
+ public long search(QueryBuilder queryBuilder, QueryCollector matcher) throws IOException {
+ IndexSearcher searcher = null;
+ try {
+ searcher = manager.acquire();
+ LazyMonitorQueryCollector collector =
+ new LazyMonitorQueryCollector(matcher, serializer, decomposer);
+ long buildTime = System.nanoTime();
+ Query query =
+ queryBuilder.buildQuery(
+ termFilters.get(searcher.getIndexReader().getReaderCacheHelper().getKey()));
+ buildTime = System.nanoTime() - buildTime;
+ searcher.search(query, collector);
+ return buildTime;
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ }
+
+ @Override
+ public void purgeCache() {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
Review comment:
Let's make this call `manager.maybeRefresh`
##########
File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##########
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.monitor;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.search.*;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.util.BytesRef;
+import org.apache.lucene.util.IOUtils;
+import org.apache.lucene.util.NamedThreadFactory;
+
+class ReadonlyQueryIndex extends QueryIndex {
+
+ private final ScheduledExecutorService refreshExecutor;
+
+ public ReadonlyQueryIndex(MonitorConfiguration configuration) throws IOException {
+ if (configuration.getDirectoryProvider() == null) {
+ throw new IllegalStateException(
+ "You must specify a Directory when configuring a Monitor as read-only.");
+ }
+ Directory directory = configuration.getDirectoryProvider().get();
+ this.manager = new SearcherManager(directory, new TermsHashBuilder(termFilters));
+ this.decomposer = configuration.getQueryDecomposer();
+ this.serializer = configuration.getQuerySerializer();
+ this.refreshExecutor =
+ Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("cache-purge"));
+ long refreshFrequency = configuration.getPurgeFrequency();
+ this.refreshExecutor.scheduleAtFixedRate(
+ () -> {
+ try {
+ manager.maybeRefresh();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ },
+ refreshFrequency,
+ refreshFrequency,
+ configuration.getPurgeFrequencyUnits());
+ }
+
+ @Override
+ public void commit(List<MonitorQuery> updates) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot commit");
+ }
+
+ @Override
+ public long search(QueryBuilder queryBuilder, QueryCollector matcher) throws IOException {
+ IndexSearcher searcher = null;
+ try {
+ searcher = manager.acquire();
+ LazyMonitorQueryCollector collector =
+ new LazyMonitorQueryCollector(matcher, serializer, decomposer);
+ long buildTime = System.nanoTime();
+ Query query =
+ queryBuilder.buildQuery(
+ termFilters.get(searcher.getIndexReader().getReaderCacheHelper().getKey()));
+ buildTime = System.nanoTime() - buildTime;
+ searcher.search(query, collector);
+ return buildTime;
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ }
+
+ @Override
+ public void purgeCache() {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ void purgeCache(CachePopulator populator) {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ public void close() throws IOException {
+ refreshExecutor.shutdown();
+ IOUtils.close(manager);
+ }
+
+ @Override
+ public int numDocs() throws IOException {
+ IndexSearcher searcher = null;
+ int numDocs;
+ try {
+ searcher = manager.acquire();
+ numDocs = searcher.getIndexReader().numDocs();
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ return numDocs;
+ }
+
+ @Override
+ public int cacheSize() {
+ return -1;
+ }
+
+ @Override
+ public void deleteQueries(List<String> ids) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot delete queries");
+ }
+
+ @Override
+ public void clear() throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot clear");
+ }
+
+ @Override
+ public long getLastPurged() {
+ return -1;
+ }
+
+ @Override
+ public void addListener(MonitorUpdateListener listener) {
+ throw new IllegalStateException("Monitor is readOnly cannot register listeners");
Review comment:
And here :)
##########
File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##########
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.monitor;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.search.*;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.util.BytesRef;
+import org.apache.lucene.util.IOUtils;
+import org.apache.lucene.util.NamedThreadFactory;
+
+class ReadonlyQueryIndex extends QueryIndex {
+
+ private final ScheduledExecutorService refreshExecutor;
+
+ public ReadonlyQueryIndex(MonitorConfiguration configuration) throws IOException {
+ if (configuration.getDirectoryProvider() == null) {
+ throw new IllegalStateException(
+ "You must specify a Directory when configuring a Monitor as read-only.");
+ }
+ Directory directory = configuration.getDirectoryProvider().get();
+ this.manager = new SearcherManager(directory, new TermsHashBuilder(termFilters));
+ this.decomposer = configuration.getQueryDecomposer();
+ this.serializer = configuration.getQuerySerializer();
+ this.refreshExecutor =
+ Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("cache-purge"));
+ long refreshFrequency = configuration.getPurgeFrequency();
+ this.refreshExecutor.scheduleAtFixedRate(
+ () -> {
+ try {
+ manager.maybeRefresh();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ },
+ refreshFrequency,
+ refreshFrequency,
+ configuration.getPurgeFrequencyUnits());
+ }
+
+ @Override
+ public void commit(List<MonitorQuery> updates) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot commit");
+ }
+
+ @Override
+ public long search(QueryBuilder queryBuilder, QueryCollector matcher) throws IOException {
+ IndexSearcher searcher = null;
+ try {
+ searcher = manager.acquire();
+ LazyMonitorQueryCollector collector =
+ new LazyMonitorQueryCollector(matcher, serializer, decomposer);
+ long buildTime = System.nanoTime();
+ Query query =
+ queryBuilder.buildQuery(
+ termFilters.get(searcher.getIndexReader().getReaderCacheHelper().getKey()));
+ buildTime = System.nanoTime() - buildTime;
+ searcher.search(query, collector);
+ return buildTime;
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ }
+
+ @Override
+ public void purgeCache() {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ void purgeCache(CachePopulator populator) {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
Review comment:
Can this throw `UnsupportedOperationException` instead?
##########
File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##########
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.monitor;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.search.*;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.util.BytesRef;
+import org.apache.lucene.util.IOUtils;
+import org.apache.lucene.util.NamedThreadFactory;
+
+class ReadonlyQueryIndex extends QueryIndex {
+
+ private final ScheduledExecutorService refreshExecutor;
+
+ public ReadonlyQueryIndex(MonitorConfiguration configuration) throws IOException {
+ if (configuration.getDirectoryProvider() == null) {
+ throw new IllegalStateException(
+ "You must specify a Directory when configuring a Monitor as read-only.");
+ }
+ Directory directory = configuration.getDirectoryProvider().get();
+ this.manager = new SearcherManager(directory, new TermsHashBuilder(termFilters));
+ this.decomposer = configuration.getQueryDecomposer();
+ this.serializer = configuration.getQuerySerializer();
+ this.refreshExecutor =
+ Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("cache-purge"));
+ long refreshFrequency = configuration.getPurgeFrequency();
+ this.refreshExecutor.scheduleAtFixedRate(
+ () -> {
+ try {
+ manager.maybeRefresh();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ },
+ refreshFrequency,
+ refreshFrequency,
+ configuration.getPurgeFrequencyUnits());
+ }
+
+ @Override
+ public void commit(List<MonitorQuery> updates) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot commit");
+ }
+
+ @Override
+ public long search(QueryBuilder queryBuilder, QueryCollector matcher) throws IOException {
+ IndexSearcher searcher = null;
+ try {
+ searcher = manager.acquire();
+ LazyMonitorQueryCollector collector =
+ new LazyMonitorQueryCollector(matcher, serializer, decomposer);
+ long buildTime = System.nanoTime();
+ Query query =
+ queryBuilder.buildQuery(
+ termFilters.get(searcher.getIndexReader().getReaderCacheHelper().getKey()));
+ buildTime = System.nanoTime() - buildTime;
+ searcher.search(query, collector);
+ return buildTime;
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ }
+
+ @Override
+ public void purgeCache() {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ void purgeCache(CachePopulator populator) {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ public void close() throws IOException {
+ refreshExecutor.shutdown();
+ IOUtils.close(manager);
+ }
+
+ @Override
+ public int numDocs() throws IOException {
+ IndexSearcher searcher = null;
+ int numDocs;
+ try {
+ searcher = manager.acquire();
+ numDocs = searcher.getIndexReader().numDocs();
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ return numDocs;
+ }
+
+ @Override
+ public int cacheSize() {
+ return -1;
+ }
+
+ @Override
+ public void deleteQueries(List<String> ids) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot delete queries");
+ }
+
+ @Override
+ public void clear() throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot clear");
+ }
+
+ @Override
+ public long getLastPurged() {
+ return -1;
+ }
+
+ @Override
+ public void addListener(MonitorUpdateListener listener) {
+ throw new IllegalStateException("Monitor is readOnly cannot register listeners");
+ }
+
+ // ---------------------------------------------
+ // Helper classes...
+ // ---------------------------------------------
+
+ /** A Collector that decodes the stored query for each document hit reparsing them everytime. */
+ static final class LazyMonitorQueryCollector extends SimpleCollector {
+ private final QueryIndex.QueryCollector matcher;
+ private final QueryIndex.DataValues dataValues = new QueryIndex.DataValues();
+ private final MonitorQuerySerializer serializer;
+ private final QueryDecomposer decomposer;
+
+ LazyMonitorQueryCollector(
+ QueryIndex.QueryCollector matcher,
+ MonitorQuerySerializer serializer,
+ QueryDecomposer decomposer) {
+ this.matcher = matcher;
+ this.serializer = serializer;
+ this.decomposer = decomposer;
+ }
+
+ @Override
+ public void setScorer(Scorable scorer) {
+ this.dataValues.scorer = scorer;
+ }
+
+ @Override
+ public void collect(int doc) throws IOException {
+ dataValues.advanceTo(doc);
+ BytesRef cache_id = dataValues.cacheId.lookupOrd(dataValues.cacheId.ordValue());
+ BytesRef query_id = dataValues.queryId.lookupOrd(dataValues.queryId.ordValue());
+ MonitorQuery mq = serializer.deserialize(dataValues.mq.binaryValue());
+ QueryCacheEntry query =
+ QueryCacheEntry.decompose(mq, decomposer).stream()
+ .filter(queryCacheEntry -> queryCacheEntry.cacheId.equals(cache_id.utf8ToString()))
+ .findFirst()
+ .orElse(null);
Review comment:
Can we throw an exception here instead? `null` is going to cause problems in the collector I think?
##########
File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##########
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.monitor;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.search.*;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.util.BytesRef;
+import org.apache.lucene.util.IOUtils;
+import org.apache.lucene.util.NamedThreadFactory;
+
+class ReadonlyQueryIndex extends QueryIndex {
+
+ private final ScheduledExecutorService refreshExecutor;
+
+ public ReadonlyQueryIndex(MonitorConfiguration configuration) throws IOException {
+ if (configuration.getDirectoryProvider() == null) {
+ throw new IllegalStateException(
+ "You must specify a Directory when configuring a Monitor as read-only.");
+ }
+ Directory directory = configuration.getDirectoryProvider().get();
+ this.manager = new SearcherManager(directory, new TermsHashBuilder(termFilters));
+ this.decomposer = configuration.getQueryDecomposer();
+ this.serializer = configuration.getQuerySerializer();
+ this.refreshExecutor =
+ Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("cache-purge"));
+ long refreshFrequency = configuration.getPurgeFrequency();
+ this.refreshExecutor.scheduleAtFixedRate(
+ () -> {
+ try {
+ manager.maybeRefresh();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ },
+ refreshFrequency,
+ refreshFrequency,
+ configuration.getPurgeFrequencyUnits());
+ }
+
+ @Override
+ public void commit(List<MonitorQuery> updates) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot commit");
+ }
+
+ @Override
+ public long search(QueryBuilder queryBuilder, QueryCollector matcher) throws IOException {
+ IndexSearcher searcher = null;
+ try {
+ searcher = manager.acquire();
+ LazyMonitorQueryCollector collector =
+ new LazyMonitorQueryCollector(matcher, serializer, decomposer);
+ long buildTime = System.nanoTime();
+ Query query =
+ queryBuilder.buildQuery(
+ termFilters.get(searcher.getIndexReader().getReaderCacheHelper().getKey()));
+ buildTime = System.nanoTime() - buildTime;
+ searcher.search(query, collector);
+ return buildTime;
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ }
+
+ @Override
+ public void purgeCache() {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ void purgeCache(CachePopulator populator) {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ public void close() throws IOException {
+ refreshExecutor.shutdown();
+ IOUtils.close(manager);
+ }
+
+ @Override
+ public int numDocs() throws IOException {
+ IndexSearcher searcher = null;
+ int numDocs;
+ try {
+ searcher = manager.acquire();
+ numDocs = searcher.getIndexReader().numDocs();
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ return numDocs;
+ }
+
+ @Override
+ public int cacheSize() {
+ return -1;
+ }
+
+ @Override
+ public void deleteQueries(List<String> ids) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot delete queries");
+ }
+
+ @Override
+ public void clear() throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot clear");
Review comment:
And here
##########
File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##########
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.lucene.monitor;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.search.*;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.util.BytesRef;
+import org.apache.lucene.util.IOUtils;
+import org.apache.lucene.util.NamedThreadFactory;
+
+class ReadonlyQueryIndex extends QueryIndex {
+
+ private final ScheduledExecutorService refreshExecutor;
+
+ public ReadonlyQueryIndex(MonitorConfiguration configuration) throws IOException {
+ if (configuration.getDirectoryProvider() == null) {
+ throw new IllegalStateException(
+ "You must specify a Directory when configuring a Monitor as read-only.");
+ }
+ Directory directory = configuration.getDirectoryProvider().get();
+ this.manager = new SearcherManager(directory, new TermsHashBuilder(termFilters));
+ this.decomposer = configuration.getQueryDecomposer();
+ this.serializer = configuration.getQuerySerializer();
+ this.refreshExecutor =
+ Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("cache-purge"));
+ long refreshFrequency = configuration.getPurgeFrequency();
+ this.refreshExecutor.scheduleAtFixedRate(
+ () -> {
+ try {
+ manager.maybeRefresh();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ },
+ refreshFrequency,
+ refreshFrequency,
+ configuration.getPurgeFrequencyUnits());
+ }
+
+ @Override
+ public void commit(List<MonitorQuery> updates) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot commit");
+ }
+
+ @Override
+ public long search(QueryBuilder queryBuilder, QueryCollector matcher) throws IOException {
+ IndexSearcher searcher = null;
+ try {
+ searcher = manager.acquire();
+ LazyMonitorQueryCollector collector =
+ new LazyMonitorQueryCollector(matcher, serializer, decomposer);
+ long buildTime = System.nanoTime();
+ Query query =
+ queryBuilder.buildQuery(
+ termFilters.get(searcher.getIndexReader().getReaderCacheHelper().getKey()));
+ buildTime = System.nanoTime() - buildTime;
+ searcher.search(query, collector);
+ return buildTime;
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ }
+
+ @Override
+ public void purgeCache() {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ void purgeCache(CachePopulator populator) {
+ throw new IllegalStateException("Monitor is readOnly, it has no cache");
+ }
+
+ @Override
+ public void close() throws IOException {
+ refreshExecutor.shutdown();
+ IOUtils.close(manager);
+ }
+
+ @Override
+ public int numDocs() throws IOException {
+ IndexSearcher searcher = null;
+ int numDocs;
+ try {
+ searcher = manager.acquire();
+ numDocs = searcher.getIndexReader().numDocs();
+ } finally {
+ if (searcher != null) {
+ manager.release(searcher);
+ }
+ }
+ return numDocs;
+ }
+
+ @Override
+ public int cacheSize() {
+ return -1;
+ }
+
+ @Override
+ public void deleteQueries(List<String> ids) throws IOException {
+ throw new IllegalStateException("Monitor is readOnly cannot delete queries");
Review comment:
Same here, this should be UnsupportedOperationException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org