You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2016/04/28 10:54:34 UTC
[GitHub] flink pull request: [FLINK-3837] [table] Create FLOOR/CEIL functio...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1943
[FLINK-3837] [table] Create FLOOR/CEIL function
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR implements the FLOOR/CEIL functions for numerical types and simplifies the existing code a little bit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink TableApiFloorCeil
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1943.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1943
----
commit 4ed70df7c022ce1d2fdba824cc92fe7f83552df5
Author: twalthr <tw...@apache.org>
Date: 2016-04-28T08:51:23Z
[FLINK-3837] [table] Create FLOOR/CEIL function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3837] [table] Create FLOOR/CEIL functio...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1943#issuecomment-216256600
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3837] [table] Create FLOOR/CEIL functio...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1943#issuecomment-216224308
Good to merge, IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3837] [table] Create FLOOR/CEIL functio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1943
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---