You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/24 00:37:12 UTC

[GitHub] [incubator-superset] betodealmeida commented on issue #7348: Feature flag for client cache

betodealmeida commented on issue #7348: Feature flag for client cache
URL: https://github.com/apache/incubator-superset/pull/7348#issuecomment-486023430
 
 
   > @betodealmeida, I just found in Chart.jsx componentDidmount, you also need to fix logic for GET vs POST.
   
   @graceguo-supercat this PR takes care of that, since it makes the actions `postChartFormData` and `getSavedChart` identical when the feature is disabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org