You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/19 13:37:35 UTC
[GitHub] [doris] ByteYue opened a new pull request, #16108: [Chore](Docs) fix error path in ssb/tpch docs
ByteYue opened a new pull request, #16108:
URL: https://github.com/apache/doris/pull/16108
# Proposed changes
Issue Number: close #xxx
I found out that the config file path inside `tpch-benchmark` along with `ssb-benchmark` is not consistent with the `load_data.sh`. In the sh file's content, the config file should lie under conf directory. It's so misleading...
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] spaces-X commented on a diff in pull request #16108: [Chore](Docs) fix error path in ssb/tpch docs
Posted by GitBox <gi...@apache.org>.
spaces-X commented on code in PR #16108:
URL: https://github.com/apache/doris/pull/16108#discussion_r1081462069
##########
docs/zh-CN/docs/benchmark/ssb.md:
##########
@@ -176,7 +176,7 @@ sh gen-ssb-data.sh -s 100 -c 100
在调用导入脚本前，需要将 FE 的 ip 端口等信息写在 `doris-cluster.conf` 文件中。
-文件位置和 `load-ssb-dimension-data.sh` 平级。
+文件位置在 `${DORIS_HOME}/tools/ssb-tools/load-ssb-dimension-data.sh` 。
Review Comment:
```suggestion
文件位置在 `${DORIS_HOME}/tools/ssb-tools/conf/` 目录下 。
```
##########
docs/zh-CN/docs/benchmark/tpch.md:
##########
@@ -159,7 +159,7 @@ sh gen-tpch-data.sh
在调用导入脚本前，需要将 FE 的 ip 端口等信息写在 `doris-cluster.conf` 文件中。
-文件位置和 `load-tpch-data.sh` 平级。
+文件位置在 `${DORIS_HOME}/tools/tpch-tools/conf/load-tpch-data.sh`。
Review Comment:
```suggestion
文件位置在 `${DORIS_HOME}/tools/tpch-tools/conf/` 目录下。
```
##########
docs/en/docs/benchmark/tpch.md:
##########
@@ -158,7 +158,7 @@ sh gen-tpch-data.sh
Before import the script, you need to write the FE’s ip port and other information in the `doris-cluster.conf` file.
-The file location is at the same level as `load-tpch-data.sh`.
+The file location is at `${DORIS_HOME}/tools/tpch-tools/conf/load-tpch-data.sh`.
Review Comment:
```suggestion
The file is located under `${DORIS_HOME}/tools/tpch-tools/conf/` .
```
##########
docs/en/docs/benchmark/ssb.md:
##########
@@ -175,7 +175,7 @@ With the `-s 100` parameter, the resulting dataset size is:
Before import the script, you need to write the FE’s ip port and other information in the `doris-cluster.conf` file.
-The file location is at the same level as `load-ssb-dimension-data.sh`.
+The file location is at `${DORIS_HOME}/tools/ssb-tools/load-ssb-dimension-data.sh`.
Review Comment:
```suggestion
The file is located under `${DORIS_HOME}/tools/ssb-tools/conf/`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16108: [Chore](Docs) fix error path in ssb/tpch docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16108:
URL: https://github.com/apache/doris/pull/16108#issuecomment-1397869199
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16108: [Chore](Docs) fix error path in ssb/tpch docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16108:
URL: https://github.com/apache/doris/pull/16108#issuecomment-1397869240
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] spaces-X merged pull request #16108: [typo](docs) fix error path in ssb/tpch docs
Posted by GitBox <gi...@apache.org>.
spaces-X merged PR #16108:
URL: https://github.com/apache/doris/pull/16108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org