You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by am...@apache.org on 2017/11/22 16:39:06 UTC
incubator-unomi git commit: UNOMI-140 : Use system tag
"personalIdentifierProperties" in privacy service (REVIEW)
Repository: incubator-unomi
Updated Branches:
refs/heads/master 9e5772630 -> 5653606cf
UNOMI-140 : Use system tag "personalIdentifierProperties" in privacy service (REVIEW)
Project: http://git-wip-us.apache.org/repos/asf/incubator-unomi/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-unomi/commit/5653606c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-unomi/tree/5653606c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-unomi/diff/5653606c
Branch: refs/heads/master
Commit: 5653606cfdab498d499a218014ca4f12d4a24175
Parents: 9e57726
Author: Abdelkader Midani <am...@apache.org>
Authored: Wed Nov 22 17:39:01 2017 +0100
Committer: Abdelkader Midani <am...@apache.org>
Committed: Wed Nov 22 17:39:01 2017 +0100
----------------------------------------------------------------------
.../apache/unomi/privacy/internal/PrivacyServiceImpl.java | 9 +++------
.../src/main/resources/OSGI-INF/blueprint/blueprint.xml | 2 +-
2 files changed, 4 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-unomi/blob/5653606c/extensions/privacy-extension/services/src/main/java/org/apache/unomi/privacy/internal/PrivacyServiceImpl.java
----------------------------------------------------------------------
diff --git a/extensions/privacy-extension/services/src/main/java/org/apache/unomi/privacy/internal/PrivacyServiceImpl.java b/extensions/privacy-extension/services/src/main/java/org/apache/unomi/privacy/internal/PrivacyServiceImpl.java
index c8fc430..72f005b 100644
--- a/extensions/privacy-extension/services/src/main/java/org/apache/unomi/privacy/internal/PrivacyServiceImpl.java
+++ b/extensions/privacy-extension/services/src/main/java/org/apache/unomi/privacy/internal/PrivacyServiceImpl.java
@@ -39,18 +39,12 @@ public class PrivacyServiceImpl implements PrivacyService {
private PersistenceService persistenceService;
private ProfileService profileService;
private EventService eventService;
- private List deniedProperties = new ArrayList<String>();
private BundleContext bundleContext;
public PrivacyServiceImpl() {
logger.info("Initializing privacy service...");
}
- public void initService() {
- Set<PropertyType> personalIdsProps = profileService.getPropertyTypeBySystemTag(ProfileService.PERSONAL_IDENTIFIER_TAG_NAME);
- personalIdsProps.forEach(propType -> deniedProperties.add(propType.getMetadata().getId()));
- }
-
public void setPersistenceService(PersistenceService persistenceService) {
this.persistenceService = persistenceService;
}
@@ -213,6 +207,9 @@ public class PrivacyServiceImpl implements PrivacyService {
@Override
public List<String> getDeniedProperties(String profileId) {
+ List deniedProperties = new ArrayList<String>();
+ Set<PropertyType> personalIdsProps = profileService.getPropertyTypeBySystemTag(ProfileService.PERSONAL_IDENTIFIER_TAG_NAME);
+ personalIdsProps.forEach(propType -> deniedProperties.add(propType.getMetadata().getId()));
return deniedProperties;
}
http://git-wip-us.apache.org/repos/asf/incubator-unomi/blob/5653606c/extensions/privacy-extension/services/src/main/resources/OSGI-INF/blueprint/blueprint.xml
----------------------------------------------------------------------
diff --git a/extensions/privacy-extension/services/src/main/resources/OSGI-INF/blueprint/blueprint.xml b/extensions/privacy-extension/services/src/main/resources/OSGI-INF/blueprint/blueprint.xml
index 294909b..8a5d2a2 100644
--- a/extensions/privacy-extension/services/src/main/resources/OSGI-INF/blueprint/blueprint.xml
+++ b/extensions/privacy-extension/services/src/main/resources/OSGI-INF/blueprint/blueprint.xml
@@ -31,7 +31,7 @@
<!-- Privacy service -->
- <bean id="privacyServiceImpl" class="org.apache.unomi.privacy.internal.PrivacyServiceImpl" init-method="initService">
+ <bean id="privacyServiceImpl" class="org.apache.unomi.privacy.internal.PrivacyServiceImpl">
<property name="persistenceService" ref="persistenceService"/>
<property name="eventService" ref="eventService" />
<property name="profileService" ref="profileService" />