You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/23 04:00:46 UTC

[GitHub] szha commented on a change in pull request #10213: [MXNET-16] move nnvm & dmlc-core to 3rdparty

szha commented on a change in pull request #10213: [MXNET-16] move nnvm & dmlc-core to 3rdparty
URL: https://github.com/apache/incubator-mxnet/pull/10213#discussion_r176634699
 
 

 ##########
 File path: amalgamation/amalgamation.py
 ##########
 @@ -149,8 +154,8 @@ def expand(x, pending, stage):
 expand.fileCount = 0
 
 # Expand the stages
-expand(sys.argv[2], [], "dmlc")
-expand(sys.argv[3], [], "nnvm")
+expand(sys.argv[2], [], "3rdparty/dmlc")
 
 Review comment:
   what's a stage in expand()? this doesn't match the existing path. is this intended?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services