You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/28 08:13:00 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #171: drivers: wireless: Return OK with 0 bytes in gs2200m_send_bulk()

masayuki2009 opened a new pull request #171: drivers: wireless: Return OK with 0 bytes in gs2200m_send_bulk()
URL: https://github.com/apache/incubator-nuttx/pull/171
 
 
   ### Summary
   
   - When GS2200M device returned WR_RESP_NOK in gs2200m_send_bulk(), a receiver side might not be ready to receive a new packet (i.e. TCP window size is zero). In previous implementation, the driver retried to send the packet in driver and give up to send when it reached a max retry count (e.g. 100).  In this implementation. I changed the max retry cont to 10 and it returns OK with 0 bytes sent when it reached to the max retry count to let an application retry to send. Also, gs2200m daemon need to be fixed which I'll send another PR later.
   
   ### Impact
   
   - This PR only affects the gs2200m driver and typically for congested network or receiver window size is zero cases. 
   
   ### Testing
   
   - To test this PR, I had to use another patch which was applied to gs2200m daemon. Test was mainly done by sending MP3 audio files from webserver on Spresense as well as telnet. And at a receiver side, I used Firefox on macOS. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jerpelea merged pull request #171: drivers: wireless: Return OK with 0 bytes in gs2200m_send_bulk()

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #171: drivers: wireless: Return OK with 0 bytes in gs2200m_send_bulk()
URL: https://github.com/apache/incubator-nuttx/pull/171
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services